Closed Bug 1220551 Opened 5 years ago Closed 5 years ago

The parameters passed to mBufferedState->NotifyDataArrived() are wrong

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

Blocks: 1219142
Assignee: nobody → jwwang
Summary: The parameters passed to mBufferedState->NotifyDataArrived() is wrong → The parameters passed to mBufferedState->NotifyDataArrived() are wrong
Blocks: 1220558
Depends on: 1218157
Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.
Attachment #8681929 - Flags: review?(jyavenard)
Bug 1220551. Part 2 - remove arguments from NotifyDataArrivedInternal(). r=jya.
Attachment #8681930 - Flags: review?(jyavenard)
Comment on attachment 8681929 [details]
MozReview Request: Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.

https://reviewboard.mozilla.org/r/23925/#review21371
Attachment #8681929 - Flags: review?(jyavenard) → review+
Comment on attachment 8681930 [details]
MozReview Request: Bug 1220551. Part 2 - remove arguments from NotifyDataArrivedInternal(). r=jya.

https://reviewboard.mozilla.org/r/23927/#review21373
Attachment #8681930 - Flags: review?(jyavenard) → review+
Thanks!
Need to uplift.
Flags: needinfo?(jwwang)
https://hg.mozilla.org/mozilla-central/rev/7728f81b8e04
https://hg.mozilla.org/mozilla-central/rev/574109522f84
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment on attachment 8681929 [details]
MozReview Request: Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.

Approval Request Comment
[Feature/regressing bug #]:1218157
[User impact if declined]:wrong buffer range might be returned and cause seek to be less accurate in rare cases.
[Describe test coverage new/current, TreeHerder]:tested on TreeHerder, so far so good
[Risks and why]: low, the fix is simple and it only affects webm playback when pref "media.format-reader.webm" is false which defaults to true.
[String/UUID change made/needed]:none
Flags: needinfo?(jwwang)
Attachment #8681929 - Flags: approval-mozilla-beta?
Attachment #8681929 - Flags: approval-mozilla-aurora?
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Comment on attachment 8681929 [details]
MozReview Request: Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.

OK, improve the video, taking it.
Should be in 43 beta 2.
Attachment #8681929 - Flags: approval-mozilla-beta?
Attachment #8681929 - Flags: approval-mozilla-beta+
Attachment #8681929 - Flags: approval-mozilla-aurora?
Attachment #8681929 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.