1220551 - The parameters passed to mBufferedState->NotifyDataArrived() are wrong

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/releases/mozilla-release/diff/0ec8472a93ac/dom/media/webm/WebMReader.cpp

We should pass |bytes->Length()| and |range.mStart| instead.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d605ad57d111

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=206225fc3d46
with WebMReader enabled.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.

Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1220551. Part 2 - remove arguments from NotifyDataArrivedInternal(). r=jya.

Bug 1220551. Part 2 - remove arguments from NotifyDataArrivedInternal(). r=jya.

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8681929 [details]
MozReview Request: Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.

https://reviewboard.mozilla.org/r/23925/#review21371

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8681930 [details]
MozReview Request: Bug 1220551. Part 2 - remove arguments from NotifyDataArrivedInternal(). r=jya.

https://reviewboard.mozilla.org/r/23927/#review21373

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7728f81b8e04
https://hg.mozilla.org/integration/mozilla-inbound/rev/574109522f84

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Need to uplift.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7728f81b8e04
https://hg.mozilla.org/mozilla-central/rev/574109522f84

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8681929 [details]
MozReview Request: Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.

Approval Request Comment
[Feature/regressing bug #]:1218157
[User impact if declined]:wrong buffer range might be returned and cause seek to be less accurate in rare cases.
[Describe test coverage new/current, TreeHerder]:tested on TreeHerder, so far so good
[Risks and why]: low, the fix is simple and it only affects webm playback when pref "media.format-reader.webm" is false which defaults to true.
[String/UUID change made/needed]:none

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7728f81b8e04
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/574109522f84

Comment 13

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8681929 [details]
MozReview Request: Bug 1220551. Part 1 - fix the parameters passed to mBufferedState->NotifyDataArrived(). r=jya.

OK, improve the video, taking it.
Should be in 43 beta 2.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/33572c767d34

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9eb17d1e915c

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/33572c767d34