1220553 - [gui] allow to select profile persistence method in the wizard

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

Attachment: mozreg-profile.png

Basically the command line has the "--profile-persistence" arg that allow to select a persistence method for the profile. Currently this is not available from the GUI, would be a nice to have.

I propose that we add a combobox with the possible values under the persist field (see the attached), clone, clone-first and reuse. clone should be the default (or maybe we can read it from the config - or do that later if the mechanism do not exist yet).

Every change should happen in the wizard.py (https://github.com/mozilla/mozregression/blob/master/gui/mozregui/wizard.py) file, and possibly in one of the .ui file to add the combobox.

Comment 1

[Julien Pagès (:parkouss)]

Note that some knowledge about PyQt is required here, but I can help for that.

Comment 2

[Saurabh Singhal [:saurabhs]]

Hi parkouss. I want to work on this bug. Though, I don't have any knowledge of PyQt.

Comment 3

[Julien Pagès (:parkouss)]

Hi Saurabh,

I'm glad you're interested by this bug!

PyQT are the Qt (http://www.qt.io/) bindings for Python - Qt is a C++ framework to build graphical applications, so PyQT (https://riverbankcomputing.com/software/pyqt/intro) allow to use the framework from Python.

You should first fork the mozregression repo (https://github.com/mozilla/mozregression), clone it locally then follow the installation process in there: https://github.com/mozilla/mozregression/blob/master/gui/README.rst.

You should then be able to run the application. Note that everything related to the GUI is under the gui/ folder.

Note that you should install also the Qt designer tool (http://doc.qt.io/qt-5/qtdesigner-manual.html) - it will help you to edit the .ui files to graphically add the combobox easily.

Please ask if you have any question, you can also ask for help on irc - https://wiki.mozilla.org/IRC (channel #ateam). my nickname there is parkouss.

Comment 4

[Sumeet (:gopianis)]

Hi there, is Saurabh still working on this?
If not, can I have a crack at it?

Comment 5

[Saurabh Singhal [:saurabhs]]

Hi GopianiS, I am actively working on this bug. Can you please look into some other bug? Thanks.

Comment 6

[Julien Pagès (:parkouss)]

(In reply to GopianiS from comment #4)
> Hi there, is Saurabh still working on this?
> If not, can I have a crack at it?

Hey GopianiS,

I will open at least one bug soon for the GUI - I'll add you on the bug CC list, so you will be notified when it will be created. Then just ask on that bug, and I'll assign it to you! Will create the bug today or tomorrow. :)

@Saurabh, I did not forget your email - will respond in a day or two also!

Comment 7

[Saurabh Singhal [:saurabhs]]

Attachment: Support for profile-persistence in the GUI

Comment 8

[Julien Pagès (:parkouss)]

Comment on attachment 8699144 [details] [review]
Support for profile-persistence in the GUI

Thanks, this looks good and works well. :)

Sorry for the delay on the review - I found bug 1233649 while testing, so I had to investigate a bit. But this is not related to your PR.

Comment 9

[Julien Pagès (:parkouss)]

Merged in https://github.com/mozilla/mozregression/commit/252197a78ee8f77fb80cd74a21a3f5fc08ac0efb.

I had some difficulties to merge it, probably because of the merge commit in your PR, https://github.com/crisron/mozregression-1/commit/32259f100f0436767c84b6d4bde2ab2f49950931. Next time it should be  better to rebase your work instead of merging, ie:

git pull --rebase https://github.com/mozilla/mozregression

when you want to take the changes from mozregression/master. You will still have to resolve conflicts if any, but then you will have a linear history.

When you do that, to push again you changes on your fork you should use:

git push -f

because the history has been rewritten with the rebase.

We can discuss that later on irc if you want. :)