1220651 - The 'Record allocation stacks' option is disabled if enabling and disabling the 'Invert tree' option

Status: RESOLVED INVALID

(DevTools :: Memory, defect)

Description

[Mihai Boldan, Desktop QA [:mboldan]]

Reproducible with Nightly 44.0a1 (2015-10-29)
Affected platforms: Windows 10 x32, Ubuntu 13.10 x64 and Mac OS X 10.11

Steps to reproduce:

1. Launch Firefox and enable the `devtools.memory.enabled` pref.
2. Enable the Toggle tools from the Developer option.
3. Select the Memory tool and click no the 'Take snapshot' button.
4. Enable 'Record allocation stacks' option.
5. Enable 'Invert tree' option.
6. Disable 'Invert tree' option.

Expected results:
The 'Record allocation stacks' checkbox is checked and the option is enabled.

Actual result:
The 'Record allocation stacks' checkbox is checked, but the option is disabled.

Note that if the 'Record allocation stacks' checkbox is unchecked after step 6 from STR, the 'Record allocation stacks' option is enabled.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Mihai Boldan, QA [:mboldan] from comment #0)
> Actual result:
> The 'Record allocation stacks' checkbox is checked, but the option is
> disabled.

What do you mean by "but the option is disabled"? The checkbox is checked but we aren't recording allocation stacks?

Comment 2

[Mihai Boldan, Desktop QA [:mboldan]]

(In reply to Nick Fitzgerald [:fitzgen][:nf] from comment #1)
> (In reply to Mihai Boldan, QA [:mboldan] from comment #0)
> > Actual result:
> > The 'Record allocation stacks' checkbox is checked, but the option is
> > disabled.
> 
> What do you mean by "but the option is disabled"? The checkbox is checked
> but we aren't recording allocation stacks?

When the 'Record allocation stacks' option is enabled,(Step 4), a list with the allocation stacks is displayed.
If the 'Invert tree' option is enabled and than disabled, the list of the allocation stack is no longer displayed, but the option is checked.
When the 'Record allocation stacks' option is unchecked, the allocation stacks are displayed.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

You shouldn't get any allocation stacks unless you were recording them *prior* to taking the heap snapshot. Viewing the allocation stacks would also require switching the "group by" selector to "allocation stack". Given the STR here, I'm not sure whether there is an issue or not, but if there is then we need more coherent STR.