Closed
Bug 1220714
Opened 9 years ago
Closed 9 years ago
use UniquePtr<T[]> instead of nsAutoArrayPtr<T> in layout/
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
8.42 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8682013 -
Flags: review?(dholbert)
Comment 2•9 years ago
|
||
Comment on attachment 8682013 [details] [diff] [review] use UniquePtr<T[]> instead of nsAutoArrayPtr<T> in layout/ Review of attachment 8682013 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. r=me with or without the suggested tweak below: ::: layout/style/CSSVariableResolver.cpp @@ +66,5 @@ > // Array of booleans, where each index is a variable ID. If an element is > // true, it indicates that the variable we have called > // EnumerateVariableReferences for has a reference to the variable with > // that ID. > + UniquePtr<bool[]> mReferences; Looks like this UniquePtr could be declared as 'const' -- it's given a value in the init list, and that value is never reassigned or reset. And making it 'const' gives a reader additional information/sanity-checking about the lifetime of the resource here. If you feel like it, feel free to make that additional tweak here (adding 'const'). I tried it locally, & it compiles just fine.
Attachment #8682013 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #2) > Looks like this UniquePtr could be declared as 'const' -- it's given a value > in the init list, and that value is never reassigned or reset. And making > it 'const' gives a reader additional information/sanity-checking about the > lifetime of the resource here. > > If you feel like it, feel free to make that additional tweak here (adding > 'const'). I tried it locally, & it compiles just fine. That's a good idea, I'll do that. Thanks for the review!
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ea3f6bb82e6c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 6•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ea3f6bb82e6c
status-b2g-v2.5:
--- → fixed
Comment 7•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•