1220714 - use UniquePtr<T[]> instead of nsAutoArrayPtr<T> in layout/

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use UniquePtr<T[]> instead of nsAutoArrayPtr<T> in layout/

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8682013 [details] [diff] [review]
use UniquePtr<T[]> instead of nsAutoArrayPtr<T> in layout/

Review of attachment 8682013 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=me with or without the suggested tweak below:

::: layout/style/CSSVariableResolver.cpp
@@ +66,5 @@
>    // Array of booleans, where each index is a variable ID.  If an element is
>    // true, it indicates that the variable we have called
>    // EnumerateVariableReferences for has a reference to the variable with
>    // that ID.
> +  UniquePtr<bool[]> mReferences;

Looks like this UniquePtr could be declared as 'const' -- it's given a value in the init list, and that value is never reassigned or reset.  And making it 'const' gives a reader additional information/sanity-checking about the lifetime of the resource here.

If you feel like it, feel free to make that additional tweak here (adding 'const'). I tried it locally, & it compiles just fine.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> Looks like this UniquePtr could be declared as 'const' -- it's given a value
> in the init list, and that value is never reassigned or reset.  And making
> it 'const' gives a reader additional information/sanity-checking about the
> lifetime of the resource here.
> 
> If you feel like it, feel free to make that additional tweak here (adding
> 'const'). I tried it locally, & it compiles just fine.

That's a good idea, I'll do that.  Thanks for the review!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea3f6bb82e6c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea3f6bb82e6c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ea3f6bb82e6c

Comment 7

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion