Closed
Bug 1220716
Opened 10 years ago
Closed 9 years ago
Remove nsICurrentCharsetListener
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: hsivonen, Assigned: spillmas)
Details
(Whiteboard: [good first bug][lang=c++])
Attachments
(2 files)
|
1.49 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.76 KB,
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
nsICurrentCharsetListener is dead code. We should remove it.
|
Reporter | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Hello!
Could I have this bug assigned to me?
Thanks!
|
|
||
Comment 3•10 years ago
|
||
All instances have been removed.
Hi there.
It didn't look like Roland's comment3 quite removed everything. I've removed the code requested, built and run the tests with all passing. Seems to be all good to me.
Attachment #8697421 -
Flags: review?(VYV03354)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8697421 [details] [diff] [review]
Revision 1
Looks good. Thanks for the contribution!
Attachment #8697421 -
Flags: review?(VYV03354) → review+
|
||
Updated•9 years ago
|
Assignee: nobody → spillmas
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•