Closed Bug 1220716 Opened 5 years ago Closed 5 years ago

Remove nsICurrentCharsetListener

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: hsivonen, Assigned: spillmas)

Details

(Whiteboard: [good first bug][lang=c++])

Attachments

(2 files)

Bug1220716.diff
1.49 KB, patch
Details | Diff | Splinter Review
Revision 1
1.76 KB, patch
emk
: review+
Details | Diff | Splinter Review 
nsICurrentCharsetListener is dead code. We should remove it.
Hello!

Could I have this bug assigned to me?

Thanks!
Attached patch Bug1220716.diff — — Splinter Review 
All instances have been removed.
Attached patch Revision 1 — — Splinter Review 
Hi there.

It didn't look like Roland's comment3 quite removed everything. I've removed the code requested, built and run the tests with all passing. Seems to be all good to me.
Attachment #8697421 - Flags: review?(VYV03354)
Comment on attachment 8697421 [details] [diff] [review]
Revision 1

Looks good. Thanks for the contribution!
Attachment #8697421 - Flags: review?(VYV03354) → review+
Assignee: nobody → spillmas
https://hg.mozilla.org/mozilla-central/rev/226e81b0312f
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.