1220730 - Fix dom/xml/test/test_bug392338.html in e10s

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

This test checks that the class info of XMLDocument has some property, but it has been converted to WebIDL, so it no longer has class info. See bug 1220313 comment 2. I want to remove it because it is disabled on e10s, and I'm working on fixing all DOM tests that are disabled on e10s.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Remove an obsolete test dealing with XMLDocument's now-nonexistent classinfo.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=244e4a566f10

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8682560 [details] [diff] [review]
Remove an obsolete test dealing with XMLDocument's now-nonexistent classinfo.

So the important part of this test is that these lines:

-      var ir = theSubject.QueryInterface(this.window.SpecialPowers.Ci
-                                             .nsIChannel).notificationCallbacks;

don't throw.  That's what bug 392338 was about.  The rest is kinda gravy.

What we should probably do is move this to a chrome mochitest or browser mochitest, whichever of those run in the parent channel....

The test _used_ to just bail out right after that line if "ir" wasn't a Document and only check the classinfo if it was a document.  Looks like that got changed in bug 460425, for what that's worth.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Make test_bug392338 work with e10s.

This changes the patch so the observer stuff is done in the chrome process.

I removed the class info stuff.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d7f5729a60b

Comment 4

[Andrew McCreight [:mccr8]]

I did put together a browser-chrome version of the test, but this seems simpler.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8683987 [details] [diff] [review]
Make test_bug392338 work with e10s.

>+        // We should be able to QI the XMLDocument to an nsIChannel, then get

You mean QI the request?

r=me with that fixed.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cda8dacfd61b

Comment 7

[Andrew McCreight [:mccr8]]

(In reply to Boris Zbarsky [:bz] from comment #5)
> You mean QI the request?

I fixed the comment.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cda8dacfd61b