1220736 - test_homescreen_delete_app.py : TimeoutException: TimeoutException: Timed out after 10.3 seconds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Max Ivanov[:MaxIvanov]]

Description: Test case fails with "TimeoutException". Looks like this happens because of changing the deletion flow.

Steps:
1. Update a flame device to 20151102030250
2. Run this test case http://lxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py

Actual result:
"TimeoutException"

Expected result:
Test completes successfully.

Repro Rate: Reproduced via Jenkins adhoc (0/5 passing)
http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc.bitbar/323/HTML_Report/

Traceback (most recent call last):
File "/var/lib/jenkins/jobs/flame-kk.ui.adhoc.bitbar/workspace/.env/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 296, in run
testMethod()
File "/var/lib/jenkins/jobs/flame-kk.ui.adhoc.bitbar/workspace/.env/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 174, in wrapper
return func(self, *args, **kwargs)
File "/var/lib/jenkins/jobs/flame-kk.ui.adhoc.bitbar/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py", line 49, in test_delete
self.homescreen.delete_app(self.app_to_delete['url']).tap_confirm()
File "/var/lib/jenkins/jobs/flame-kk.ui.adhoc.bitbar/workspace/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/confirm_dialog.py", line 22, in tap_confirm
*self._confirm_button_locator))
File "/var/lib/jenkins/jobs/flame-kk.ui.adhoc.bitbar/workspace/.env/lib/python2.7/site-packages/marionette_driver-1.0.0-py2.7.egg/marionette_driver/wait.py", line 143, in until
cause=last_exc)
TimeoutException: TimeoutException: Timed out after 10.2 seconds

Comment 1

[Martijn Wargers (dead)]

It looks like there is an edit mode again in the Homescreen app.
We need get something back like the activate_edit_mode at: https://github.com/mozilla-b2g/gaia/commit/717981856b06dc54da55c830d8d094deef13bce3#diff-78cdc65b905b94bb902e8370bd9d9de8
And after that mode is ready, the icon needs to move again to the trash can (that part might still work).

Isabel, do you think you can handle this bug?

Comment 2

[Isabel Rios[:isabel_rios]]

I will try

Comment 3

[Isabel Rios[:isabel_rios]]

The flow to delete an app has changed. Now it is not necessary to move it but to long tap on it to get the option to remove it. So I changed a little bit the approach but cannot get the two test cases working, only the first one.

Here is the pull request: https://github.com/mozilla-b2g/gaia/pull/32979

Thank you!

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] isabelrios:delete_app_homescreen > mozilla-b2g:master

Comment 5

[Isabel Rios[:isabel_rios]]

Sorry, the attachment was created automatically and I still have two commits instead of only one.
But this is strange, when I do git rebase -i HEAD~2, the first commit I see, I have not used that name and looks like the one for another bug:
pick 972c44b Bug 1219289 - Remove "unstable" Jenkins jobs
pick fcf58ab delete app from home screen

I do not know what could have happened, do you have an idea about that? 
Thanks!

Comment 6

[Martijn Wargers (dead)]

Comment on attachment 8682624 [details] [review]
[gaia] isabelrios:delete_app_homescreen > mozilla-b2g:master

Looks good, but I think we could improve this code a bit.

Comment 7

[Isabel Rios[:isabel_rios]]

Thanks Martijn, I will do the changes requested.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8682624 [details] [review]
[gaia] isabelrios:delete_app_homescreen > mozilla-b2g:master

Glad to see this test is back passing locally. Like Martijn said, there are some improvements we can make.

Comment 9

[Isabel Rios[:isabel_rios]]

Thank you for the review. 
Working on the changes needed.

Comment 10

[Isabel Rios[:isabel_rios]]

I committed new changes as requested but adding the init and change the BottomBar to PageRegion is not working, I do not get the test passing with those two changes. Would need some help to understand the problem here. 
Thanks

Comment 11

[Isabel Rios[:isabel_rios]]

New changes done, now the test is passing locally. Asking for review.

Comment 12

[Martijn Wargers (dead)]

Comment on attachment 8682624 [details] [review]
[gaia] isabelrios:delete_app_homescreen > mozilla-b2g:master

I'm fine with this. There are some nits I mentioned in the pull request you could fix.

Comment 13

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8682624 [details] [review]
[gaia] isabelrios:delete_app_homescreen > mozilla-b2g:master

Like said on IRC, the wait condition on the bottom bar is always true, which makes the wait not waiting. This can cause intermittent issues. Once that and the nits Martijn called out, that should be good to land.

Comment 14

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8682624 [details] [review]
[gaia] isabelrios:delete_app_homescreen > mozilla-b2g:master

The test looks good to me, and passes locally. Thank you!

Comment 15

[Isabel Rios[:isabel_rios]]

Thaks for the review.
Merged in master: https://github.com/mozilla-b2g/gaia/commit/aadb9e9a0dcd5e7297ae48fa974598f87127bd77