Closed
Bug 1220763
Opened 9 years ago
Closed 9 years ago
43.0b1 build1 osx en-US beta build failing to upload
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox41 unaffected, firefox42 unaffected, firefox43 fixed, firefox44 fixed, firefox45 fixed, firefox-esr38 unaffected, b2g-v2.5 fixed)
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox41 | --- | unaffected |
firefox42 | --- | unaffected |
firefox43 | --- | fixed |
firefox44 | --- | fixed |
firefox45 | --- | fixed |
firefox-esr38 | --- | unaffected |
b2g-v2.5 | --- | fixed |
People
(Reporter: jlund, Assigned: jlund)
References
Details
Attachments
(1 file, 1 obsolete file)
760 bytes,
patch
|
glandium
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
python /builds/slave/rel-m-beta-m64_bld-00000000000/tools/release/signing/signtool.py --cachedir /builds/slave/rel-m-beta-m64_bld-00000000000/signing_cache -t /builds/slave/rel-m-beta-m64_bld-00000000000/token -n /builds/slave/rel-m-beta-m64_bld-00000000000/nonce -c /builds/slave/rel-m-beta-m64_bld-00000000000/tools/release/signing/host.cert -H gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing4.srv.releng.scl3.mozilla.com:9120 -H gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing5.srv.releng.scl3.mozilla.com:9120 -H gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing6.srv.releng.scl3.mozilla.com:9120 -H dmgv2:mac-v2-signing1.srv.releng.scl3.mozilla.com:9120 -H dmgv2:mac-v2-signing2.srv.releng.scl3.mozilla.com:9120 -H dmgv2:mac-v2-signing3.srv.releng.scl3.mozilla.com:9120 -H dmgv2:mac-v2-signing4.srv.releng.scl3.mozilla.com:9120 -H dmgv2:mac-v2-signing6.srv.releng.scl3.mozilla.com:9120 -H dmgv2:mac-v2-signing7.srv.releng.scl3.mozilla.com:9120 -f gpg '../../dist/mac/en-US//firefox-43.0b1.checksums'
2015-11-02 04:37:54,044 - c29a0297b8c20f91405cd60402bb535f8952f68c: exists in the cache; copying to ../../dist/mac/en-US//firefox-43.0b1.checksums.asc
2015-11-02 04:37:54,044 - c29a0297b8c20f91405cd60402bb535f8952f68c: OK
/builds/slave/rel-m-beta-m64_bld-00000000000/build/obj-firefox/x86_64/_virtualenv/bin/python /builds/slave/rel-m-beta-m64_bld-00000000000/build/build/upload.py --base-path ../../dist \
--package mac/en-US/Firefox 43.0b1.dmg \
--properties-file ../../dist/mach_build_properties.json \
'../../dist/mac/en-US/Firefox 43.0b1.dmg' '../../dist/update/mac/en-US/firefox-43.0b1.complete.mar' '../../dist/mac/xpi/en-US.xpi' '../../dist/mac/en-US/Firefox 43.0b1.crashreporter-symbols.zip' '../../dist/mac/en-US//firefox-43.0b1.txt' '../../dist/mac/en-US//firefox-43.0b1.json' '../../dist/mac/en-US//firefox-43.0b1.mozinfo.json' '../../dist/jsshell-mac.zip' ../../dist/macosx64_info.txt ../../dist/update/mac/en-US/firefox-42.0b7-43.0b1.partial.mar ../../dist/update/mac/en-US/firefox-42.0b8-43.0b1.partial.mar ../../dist/update/mac/en-US/firefox-42.0b9-43.0b1.partial.mar ../../dist/host/bin/mar ../../dist/host/bin/mbsdiff ../../dist/host/bin/mar ../../dist/host/bin/mbsdiff \
'../../dist/mac/en-US//firefox-43.0b1.checksums' '../../dist/mac/en-US//firefox-43.0b1.checksums'.asc
File not found: /builds/slave/rel-m-beta-m64_bld-00000000000/build/obj-firefox/x86_64/browser/installer/43.0b1.dmg
make[1]: *** [upload] Error 1
make: *** [upload] Error 2
retry: Giving up on <function run_with_timeout at 0x1004eec08>
Unable to successfully run ['make', 'upload'] after 5 attempts
related: 1220018
Assignee | ||
Comment 1•9 years ago
|
||
I got all caught up in the 'MOZ_CURRENT_PROJECT' everything uni osx mindset...
> --package mac/en-US/Firefox 43.0b1.dmg \
nick noticed that the real issue here is the ^ space in the filename and the new beta post uplift code not liking it: http://hg.mozilla.org/releases/mozilla-beta/rev/e15f2c2caaff#l4.12
Comment 2•9 years ago
|
||
Yep, pretty names in use for the first time for this code.
Blocks: 1211313
Component: Release Automation → Build Config
Product: Release Engineering → Core
QA Contact: bhearsum
Summary: 43.0b1 build1 osx en-us beta build failing to upload, missing MOZ_CURRENT_PROJECT env var → 43.0b1 build1 osx en-US beta build failing to upload
Comment 3•9 years ago
|
||
glandium, the --package arg is used to write properties for later taskcluster uploads. It has no effect on the release automation, but the space in
--package mac/en-US/Firefox 43.0b1.dmg
results in upload.py thinking it needs to upload 43.0b1.dmg. So this is a regression from previous behaviour, much as I know you love MOZ_PKG_PRETTYNAMES.
Approval Request Comment
[Feature/regressing bug #]: Unknown
[User impact if declined]: no en-US build for betas
[Describe test coverage new/current, TreeHerder]: none, this would have no effect on m-a and lower unless there's a syntax error
[Risks and why]: still no en-US build for betas
[String/UUID change made/needed]: none
Attachment #8682317 -
Flags: review?(mh+mozilla)
Attachment #8682317 -
Flags: approval-mozilla-beta?
Attachment #8682317 -
Flags: approval-mozilla-aurora?
Comment 4•9 years ago
|
||
Comment on attachment 8682317 [details] [diff] [review]
[gecko] Use QUOTED_WILDCARD like upload-files.mk does
Review of attachment 8682317 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/mozapps/installer/packager.mk
@@ +207,5 @@
>
>
> upload: checksum
> $(PYTHON) $(MOZILLA_DIR)/build/upload.py --base-path $(DIST) \
> + --package $(call QUOTED_WILDCARD,$(PACKAGE)) \
You don't need QUOTED_WILDCARD, you just need to add quotes around $(PACKAGE).
Attachment #8682317 -
Flags: review?(mh+mozilla) → feedback-
Comment 5•9 years ago
|
||
Attachment #8682317 -
Attachment is obsolete: true
Attachment #8682317 -
Flags: approval-mozilla-beta?
Attachment #8682317 -
Flags: approval-mozilla-aurora?
Attachment #8682322 -
Flags: review?(mh+mozilla)
Attachment #8682322 -
Flags: approval-mozilla-beta?
Attachment #8682322 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8682322 -
Flags: review?(mh+mozilla) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8682322 [details] [diff] [review]
[gecko] Use simple quoting
Please uplift this to beta and aurora so we can do a beta 1 build 2.
Attachment #8682322 -
Flags: approval-mozilla-beta?
Attachment #8682322 -
Flags: approval-mozilla-beta+
Attachment #8682322 -
Flags: approval-mozilla-aurora?
Attachment #8682322 -
Flags: approval-mozilla-aurora+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/d64148d6bb60
https://hg.mozilla.org/releases/mozilla-aurora/rev/bc9c6e996006
https://hg.mozilla.org/integration/mozilla-inbound/rev/390c29c2ad71
status-firefox41:
--- → unaffected
status-firefox42:
--- → unaffected
status-firefox43:
--- → fixed
status-firefox44:
--- → fixed
status-firefox45:
--- → fixed
status-firefox-esr38:
--- → unaffected
Version: unspecified → 45 Branch
Comment 9•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 10•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
Comment 11•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
Comment 12•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•