1220803 - Implement a move constructor for OrderedHashTable and use it for save/restore

Status: ASSIGNED

(Core :: JavaScript: GC, defect)

Description

[Steve Fink [:sfink] [:s:]]

gcWeakKeys saving/restoring (for DEBUG-only validation) does manual iterations over the whole table.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Implement a move constructor for OrderedHashTable and use it for save/restore

I originally wanted this as part of a patch to move gcWeakRefs into gcWeakKeys. I'm giving up on that approach, but it's still a simplification. I also originally didn't want to bloat up Zone just for this stupid validation-only thing, but then I realized it's DEBUG only so there's no reason not to.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8682109 [details] [diff] [review]
Implement a move constructor for OrderedHashTable and use it for save/restore

Review of attachment 8682109 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35922f2e5876

Comment 4

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d45219fe7a2f

Comment 5

[Steve Fink [:sfink] [:s:]]

I'm confusing myself somehow, because I had a good try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b75463bbe7a

Perhaps I pushed something different?