Open
Bug 1220803
Opened 9 years ago
Updated 2 years ago
Implement a move constructor for OrderedHashTable and use it for save/restore
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
ASSIGNED
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
6.06 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
gcWeakKeys saving/restoring (for DEBUG-only validation) does manual iterations over the whole table.
Assignee | ||
Comment 1•9 years ago
|
||
I originally wanted this as part of a patch to move gcWeakRefs into gcWeakKeys. I'm giving up on that approach, but it's still a simplification. I also originally didn't want to bloat up Zone just for this stupid validation-only thing, but then I realized it's DEBUG only so there's no reason not to.
Attachment #8682109 -
Flags: review?(terrence)
Comment 2•9 years ago
|
||
Comment on attachment 8682109 [details] [diff] [review] Implement a move constructor for OrderedHashTable and use it for save/restore Review of attachment 8682109 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8682109 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 5•9 years ago
|
||
I'm confusing myself somehow, because I had a good try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b75463bbe7a Perhaps I pushed something different?
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•