1220833 - Update data reporting notification to point to privacy preference screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

Right now it points to the vendor screen, since that's where data choices are, but that's changing with bug 1216257.

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1220833 - Update data reporting notification to point to privacy preference screen. r=sebastian

Bug 1220833 - Update data reporting notification to point to privacy preference screen. r=sebastian

Comment 3

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1220833 - (Part 2) Properly select header on tablet when launching preference screen directly. r=sebastian

Bug 1220833 - (Part 2) Properly select header on tablet when launching preference screen directly. r=sebastian

Comment 4

[:Margaret Leibovic]

Somewhat surprisingly, I found that `activity.isMultiPane()` returns true on my N5x, so I had to add a null check to `switchToHeader`, since it could end up being called on a device that doesn't actually have headers to show.

Also, note that the problem for my second patch is an old pre-existing issue (I could reproduce on release), so this is just making things better :)

Comment 5

[:Margaret Leibovic]

Comment on attachment 8683153 [details]
MozReview Request: Bug 1220833 - (Part 2) Properly select header on tablet when launching preference screen directly. r=sebastian

Bug 1220833 - (Part 2) Properly select header on tablet when launching preference screen directly. r=sebastian

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8683152 [details]
MozReview Request: Bug 1220833 - Update data reporting notification to point to privacy preference screen. r=sebastian

https://reviewboard.mozilla.org/r/24199/#review21827

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8683153 [details]
MozReview Request: Bug 1220833 - (Part 2) Properly select header on tablet when launching preference screen directly. r=sebastian

https://reviewboard.mozilla.org/r/24201/#review21917

::: mobile/android/base/preferences/GeckoPreferences.java:516
(Diff revision 2)
> +        while (iterator.hasNext()) {

nit: As the iterator is only used for looping, maybe a for-each looper would be easier to read?

for (Header header : mHeaders) {
..
}

::: mobile/android/base/preferences/GeckoPreferences.java:518
(Diff revision 2)
> +            if (header.id == id) {
> +                switchToHeader(header);
> +            }

Should we return after finding the header?

::: mobile/android/base/preferences/GeckoPreferences.java:518
(Diff revision 2)
> +            if (header.id == id) {
> +                switchToHeader(header);
> +            }

Should we return after finding the header?

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/b51d63ae93a5241edeb8791d00b9cf202944f712
Bug 1220833 - Update data reporting notification to point to privacy preference screen. r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/4e951da373d703bce17600cea9ac9b0f509c84e5
Bug 1220833 - (Part 2) Properly select header on tablet when launching preference screen directly. r=sebastian

Comment 9

[:Margaret Leibovic]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b7a9bcef9ed

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/e097f75e306eaf010266b61e19529454c87fa252
Bug 1220833 - (Part 2) Properly select header on tablet when launching preference screen directly. r=sebastian

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b51d63ae93a5

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e097f75e306e

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Tapping "Choose what to share" button, opens "Privacy" sub-menu, so:
Verified as fixed using:
Device: Nexus 9 (Android 6.0) and Xiaomi Mi i4 (Android 5.0.2)