Closed Bug 1220982 Opened 9 years ago Closed 9 years ago

Migrate Calendar app to NotificationHelper

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: heidi.kasemir, Assigned: heidi.kasemir, Mentored)

References

Details

Attachments

(1 file)

[gaia] hkasemir:1220982-calendar-NotificationHelper > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36
Assignee: nobody → heidi.kasemir
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: migrate calendar app to NotificationHelper → migrate Calendar app to NotificationHelper
Mentor: gandalf
Status: NEW → ASSIGNED
Summary: migrate Calendar app to NotificationHelper → Migrate Calendar app to NotificationHelper
Comment on attachment 8682623 [details] [review] [gaia] hkasemir:1220982-calendar-NotificationHelper > mozilla-b2g:master Hi Kevin, requesting a review for this PR to move calendar app to notificationHelper API. Could you either take a look or recommend someone else to give a review? Thanks!
Attachment #8682623 - Flags: review?(kevingrandon)
Comment on attachment 8682623 [details] [review] [gaia] hkasemir:1220982-calendar-NotificationHelper > mozilla-b2g:master Seems fine to me, but I think Gareth should take a look. Thanks for the patch!
Attachment #8682623 - Flags: review?(kevingrandon) → review?(gaye)
Gaye, can you review this patch pls?
Flags: needinfo?(gaye)
I thought that NotificationHelper used the old mozNotifications under the hood and that we were supposed to migrate to the new constructor api a while ago. Did something change?
Flags: needinfo?(gaye)
Yeah. NotificationHelper uses new Notification API :) (bug 1095109)
I have a few nits on GH but I am fine with high-level stuff
:gaye, comments addressed, can you review this?
Flags: needinfo?(gaye)
Comment on attachment 8682623 [details] [review] [gaia] hkasemir:1220982-calendar-NotificationHelper > mozilla-b2g:master LGTM with a single style nit
Flags: needinfo?(gaye)
Attachment #8682623 - Flags: review?(gaye) → review+
I fixed the nit and squashed the commits, should be ready for checkin unless you see anything else that should be changed!
Thank you for your contribution Heidi! Commit: https://github.com/mozilla-b2g/gaia/commit/17dddd83a20d1f4a53d535e666b0a1e02ac19ac6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: