122107 - [ActiveX] window.open failure

Status: RESOLVED DUPLICATE of bug 149307

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Aaron Graves]

When a new window is called from a webpage (either a javascript command, or
clicking a link that should open a new window) the new window opens, but it
remains blank. However, when you right click on the link, and select "Open in
new window" it works just fine.

Comment 1

[Shark Daddy (Jonathan L.)]

Reporter, could you please give the BuildID and confirm that Javascript and
'Open unrequested windows' are enabled? *Shouldn't* make much of a difference,
but has in the past. Also, a URL would be good; I can't confirm this, because
whereever I go it works fine.

Final note: Why 1.01?

Comment 2

[Adam Lock]

1.1 alpha. 

The reason this isn't fixed sooner is because 1.0 release is so hectic at the
moment.

Comment 3

[Peter Ryall]

Don't know if you know this already but when I have that problem, it only 
occurs when the window.open specifies a window size. As I can't figure where to 
get the required window size from the events, I can't resize the new window and 
the layout seems to give up as the size is wrong. Maybe you could implement 
DWebBrowserEvents2 fully so that ClientToHostWindow fires.

Am using 1.0RC1
If you want more info just ask.

Comment 4

[Adam Lock]

Can you attach a sample URL?

Bug 149307 deals with a similar situation which we've discovered is due to
methods in the embedders IEmbeddingSiteWindow (i.e. in the control) returning
error codes.

Comment 5

[Adam Lock]

My guess is controls CWebBrowserContainer object needs to implement
nsIEmbeddingSiteWindow2 and also return NS_OK from the following embedding site
window methods:

CWebBrowserContainer::GetDimensions(PRUint32 aFlags, PRInt32 *x, PRInt32 *y,
CWebBrowserContainer::SetDimensions(PRUint32 aFlags, PRInt32 x, PRInt32 y,
CWebBrowserContainer::GetSiteWindow(void **aParentNativeWindow)
CWebBrowserContainer::SetFocus(void)
CWebBrowserContainer::GetVisibility(PRBool *aVisibility)
CWebBrowserContainer::SetVisibility(PRBool aVisibility)

The current impl returns NS_ERROR_FAILURE which might cause JS to halt because
it thinks an exception has occurred.

Comment 6

[Adam Lock]

I checked in versions of these methods that don't return error codes & also an
impl of nsIEmbeddingSiteWindow2.

The remainder is probably a dupe of bug 149307, so I'm marking it as such.

*** This bug has been marked as a duplicate of 149307 ***