1221073 - Back to 512 tile size on HiDPI OS X

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Markus Stange [:mstange]]

Before bug 1210351, we were using 512 on non-HiDPI OS X and 1024 on HiDPI OS X. We're no longer using 1024 because we're capping the tile size at 512 now.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Patch v1

Revert my patch for bug 1210351, but make snorp's heuristic aim for between 2 and 4 tiles per screen width, rather than between 1 and 2. Gives us 1024 on macbook pros, but keeps it at 512 on android phones with screen widths of 1440. (which is why we reduced it in the first place)

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8696785 [details] [diff] [review]
Patch v1

Review of attachment 8696785 [details] [diff] [review]:
-----------------------------------------------------------------

Please use clamped() from nsAlgorithm.h.

Comment 3

[Jamie Nicol [:jnicol]]

Attachment: Patch v2

Oops, the commit message was meant to say >2 <=4, not >=2 <4. Code is unchanged.

Comment 4

[Jamie Nicol [:jnicol]]

Attachment: Patch v3

Use clamped

Comment 5

[Jamie Nicol [:jnicol]]

Successful try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bec96d4b057

requesting checkin please. thanks.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d2001daa6a2

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9d2001daa6a2