Closed Bug 1221094 Opened 6 years ago Closed 6 years ago

Not using tiles for PaintedLayers inside scrolled active transforms

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox45 --- affected
firefox48 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached file testcase
If you scroll the testcase with paint flashing on, you'll see regular invalidations of the whole page because the SingleTiledContentClient is resized as different amounts of text are put into the display port.

We're not using tiles here because the loop inside ContainerState::GetLayerCreationHint stops at mContainerAnimatedGeometryRoot.
Hmm, using tiles here doesn't prevent the invalidations.
Attached patch use-tiles (obsolete) — Splinter Review
The invalidations are actually a new manifestation of bug 1164227 (invalid region simplification crosses unchanged stuff in the middle) and I'll file a new bug about them.
Attachment #8682530 - Attachment is obsolete: true
Comment on attachment 8703140 [details]
MozReview Request: Bug 1221094 - Don't mutate local mParameters with stuff that we only want to pass somewhere else. r?mattwoodrow

https://reviewboard.mozilla.org/r/29279/#review26945
Attachment #8703140 - Flags: review?(matt.woodrow) → review+
Attachment #8703141 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8703141 [details]
MozReview Request: Bug 1221094 - Detect scrollability (for using tiled layers) through container layers. r?mattwoodrow

https://reviewboard.mozilla.org/r/29281/#review26947
This causes layout/reftests/bugs/1078262-1.html to fail on B2G:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b37065fb708c&selectedJob=15281327

It looks like there are black seams between the tiles in the layer for #inner, which doesn't make any sense to me.
https://hg.mozilla.org/mozilla-central/rev/6d40b86b8cc1
https://hg.mozilla.org/mozilla-central/rev/70f69c94da8c
https://hg.mozilla.org/mozilla-central/rev/d5d0a9a548fe
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.