122115 - get autoconf build system working with current C SDK

Status: VERIFIED FIXED

(Directory :: LDAP C SDK, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: first cut at updating autoconf build system

Here's a first cut at updating the C SDK tip so that it can build using
autoconf.  Stuff that I still need to look into: 

Understand genMakefile.client and existing Makefiles (not Makefile.clients).

Test without an objdir.

Implement --with-system-nspr.

Comment 2

[Mark Smith [:mcs]]

I do not think anything or anyone uses the existing Makefiles (the Netscape
server and Sun builds use Makefile.client).

genMakefile.client is used to create new .def files for Windows DLLs and .exp
files for MacOS builds. On UNIX (last I knew) we generate the necessary linker
export file on the fly using a Perl script.  We should get rid of
genMakefile.client and do this on the fly always.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: SDK autoconf build patch, v2

* Added a (not-yet-working) Makefile.in to ldap/tools/clients.
* Added aclocal.m4 in preparation for --with-system-nspr
* Got rid of some NSPR-specific stuff in config/
* Copied config/autoconf/nspr.m4 from the toplevel locally in preparation for
--with-system-nspr

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for ldapcsdk_branch_50, v3

* Added .cvsignore files for srcdir builds
* Build the config subdir automagically
* Include component_versions.mk in all cases, not just HAVE_CCONF
* Add code for --without-system-nspr to configure.in; not yet working
* Clean up autoconf.mk.in and merge in recent changes from nsprpub version to
pick up --with-dist-prefix changes
* Add altoptions.m4 to allow for --without-system-nspr

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for ldapcdk_branch_50, v4

* configure.in: mkdir ldap/client by hand for objdir builds
* config/autoconf.mk.in: got rid of NO_MDUPDATE, as this should no 
  longer be necessary
* ldap/build/Makefile.in: fixed executable name bug & srcdir bug
* ldap/client/tools/Makefile.in: fixed MOD_DEPTH issue
* ldap/include/portable.h, ldap/libraries/libldap/{tmplout,request}.c:
  removed unnecessary linux build change
* excised unused cruft from configure.in/autoconf.mk.in
* updated README.configure

Comment 6

[cboatwri]

(rising from the ashes)  I did a bunch of work on this a _while_ ago.  dmose
convinced me that I have too much free time, and should finish what I started...

I don't have NT compilers right now, so I am limiited to *nix builds.

--chuck

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for ldapcsdk_branch_50, v5

This update removes a "Makefile" which shouldn't have been part of the previous
diff, and fixes the manual mkdir stuff for ldap/clients/tools in an objdir (but
gets it right this time :-).

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for ldapcsdk_branch_50, v6

Previous patch didn't include the file removals.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for ldapcsdk_branch_50, v7

Install libldap50.so into $(dist_bindir) also, because the client is lame
enough to require it there.

Comment 10

[hacker formerly known as [e-mail]]

Looking at v7,

Wrt USE_AUTOCONF ifdefs in build.mk, wouldn't it be less confusing to just add
AR_FLAGS to the default rules?  They should be unset for the non-autoconf case.

You shouldn't need altoptions.m4 to handle --without-system-nspr.  You could use
AC_ARG_WITH instead of MOZ_ARG_WITHOUT_BOOL.  The custom moz macro really
doesn't by you anything unless you're planning on making a build configurator
script similar to the one for Mozilla.

You might want to use a $(LIB_PREFIX) to cleanly handle the fact that Win32 and
OS/2 don't use 'lib' in their non-gcc builds.

The rest of the changes look ok but I haven't tested the patch.  (I'm going to
pretend that I didn't see all of those platform ifdefs.)

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for ldapcsdk branch, v8

Fixes the AR_FLAGS and --with-nspr stuff mentioned by cls.  I left the
LIB_PREFIX alone for the moment, because right now I'm trying to deviate from
the original Makefile.client files as little as possible, and they already do
solve this problem, though not as cleanly as LIB_PREFIX would.

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for ldapcsdk branch, v9

Added back COMPVERSIONSDIR to build.mk at the request of mcs so that it can be
overridden from the command-line by vendors.

Comment 13

[Mark Smith [:mcs]]

The build.mk changes contained in the v9 patch look fine to me. I don't think
any of the other changes will affect builds that do not use autoconf.

Comment 14

[hacker formerly known as [e-mail]]

Comment on attachment 69099 [details] [diff] [review]
autoconf patch for ldapcsdk branch, v9

Little nits:
In c-sdk/config/Makefile.in, why is OS2 being removed from the PROG_SUFFIX=.exe
list? Likewise for the targets list & nsinstall.c .  We really don't need to
build multiple versions of nsinstall, especially since all of the port changes
haven't been propogated. 

Altoptions.m4/MOZ_BOOL is still being used.

In ldap/include/Makefile.in, you should use $(PERL) instead of perl.

Comment 15

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for ldapcsdk branch, v10

In my last patch, I did the "cvs diff" the wrong tree.	Sorry about that.  This
patch fixes the perl -> $(PERL) thing, and all the other things should be fixed
by virtue of the fact that this time I diffed the right tree.

Comment 16

[hacker formerly known as [e-mail]]

Comment on attachment 69310 [details] [diff] [review]
autoconf patch for ldapcsdk branch, v10

r=cls

Comment 17

[Dan Mosedale (:dmosedale, :dmose)]

v10 patch has been checked in.  next step: test on windows, and make any
necessary mods for that.

Comment 18

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for windows, v1

Comment 19

[Dan Mosedale (:dmosedale, :dmose)]

OK, this latest patch makes it build on windows and hopefully doesn't break
anything on any other platform.  Currently, if using |gmake| rather than |make|
on Windows, it needs to be called with "SHELL=bash" on command-line to gmake.

Comment 20

[hacker formerly known as [e-mail]]

Comment on attachment 70584 [details] [diff] [review]
autoconf patch for windows, v1

In gmakefile.win, you should use $(MAKE) to invoke additonal make processes
rather than hardcoding gmake.  Fix that && r=cls

Comment 21

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for windows, v2

With cls' requested change.

Comment 22

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 71753 [details] [diff] [review]
autoconf patch for windows, v2

Carrying forward cls' has-review bit.

Comment 23

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: autoconf patch for windows, v3

Fixes all platforms to give a reasonable default to $(DIST) that works when
running configure without arguments.

Comment 24

[hacker formerly known as [e-mail]]

Comment on attachment 71756 [details] [diff] [review]
autoconf patch for windows, v3

r=cls

Comment 25

[Dan Mosedale (:dmosedale, :dmose)]

Windows fix checked in.

Comment 26

[yulian chang]

Verified with 20020320 trunk builds on various platforms. Autocomplete and
addressbook search work well.