Closed Bug 1221152 Opened 9 years ago Closed 9 years ago

Add support for T3 (seagull)

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

Product:
Firefox OS Graveyard
Component:
GonkIntegration
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nicodel, Assigned: nicodel, Mentored)

References

Details

Attachments

(3 files, 5 obsolete files)

B2G Seagull PR
43 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
Seagull Manifest PR
52 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
Seagull device PR
57 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
The Xperia T3 is one of the Yukon based devices.
Attached file Seagull device PR (obsolete) —
Attached patch seagull_B2G_492.patch (obsolete) — — Splinter Review
Sorry, first one is a mistake. This one replace it.
Attachment #8690856 - Attachment is patch: false
Attachment #8690856 - Attachment is obsolete: true
Attachment #8690859 - Attachment is obsolete: true
Attached file B2G Seagull PR (obsolete) —
Attachment #8690865 - Flags: review+
Attachment #8690865 - Flags: review+
Attached file Seagull Manifest PR (obsolete) —
Attachment #8690865 - Attachment description: Seagull device PR → B2G Seagull PR
For the device-sony-seagull repository, I could not make a PR because no repository (device-sony-seagull) exist on mozilla-b2g. Here are the url and branch I used to sucessfully boot a T3 (with no B2G logo :-(...) https://github.com/nicodel/device-sony-seagull/tree/sony-aosp-l
I commented on the device tree. Fix the density ( 2.0 -> 2 ) and squash all the commits into one commit. After that you are good!
Done !
I also squash the various commits presents in the pull requests into single commit.
Blocks: 1175254
Assignee: nobody → nicolas
Status: NEW → ASSIGNED
Attachment #8690865 - Flags: review?(lissyx+mozillians)
Attachment #8690868 - Flags: review?(lissyx+mozillians)
Both branches are not green and/or in conflict :( Can you fix those before I review? Thanks!
Flags: needinfo?(nicolas)
Attachment #8690865 - Flags: review?(lissyx+mozillians)
Attachment #8690868 - Flags: review?(lissyx+mozillians)
(In reply to Alexandre LISSY :gerard-majax from comment #9) > Both branches are not green and/or in conflict :( Can you fix those before I > review? > > Thanks! Sorry, I'll fix that How should I proceed for the device tree, which cannot be PR into mozilla-B2G as no similar repo exists ?
Flags: needinfo?(nicolas)
If you are referring to device/sony/seagull I need to fork it so you can PR
Depends on: 1226694
Attached file Seagull device PR (obsolete) —
Attachment #8694377 - Flags: review?(lissyx+mozillians)
Attached file B2G Seagull PR —
Attachment #8690865 - Attachment is obsolete: true
Attachment #8694386 - Flags: review?(lissyx+mozillians)
Attached file Seagull Manifest PR —
Attachment #8690868 - Attachment is obsolete: true
Attachment #8694391 - Flags: review?(lissyx+mozillians)
Comment on attachment 8694377 [details] [review] Seagull device PR Looks good but please fix the comments on github
Attachment #8694377 - Flags: review?(lissyx+mozillians)
Attachment #8694386 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8694391 [details] [review] Seagull Manifest PR Please rebase
Attachment #8694391 - Flags: review?(lissyx+mozillians)
Comment on attachment 8694377 [details] [review] Seagull device PR line of code modified as requested and commits rebased into one.
Attachment #8694377 - Flags: review?(lissyx+mozillians)
Comment on attachment 8694391 [details] [review] Seagull Manifest PR Commits rebased
Attachment #8694391 - Flags: review?(lissyx+mozillians)
Comment on attachment 8694377 [details] [review] Seagull device PR Good but you still need to fix the aosp_d5103.mk :(
Attachment #8694377 - Flags: review?(lissyx+mozillians) → review+
Attachment #8694391 - Flags: review?(lissyx+mozillians) → review+
(In reply to Alexandre LISSY :gerard-majax from comment #19) > Comment on attachment 8694377 [details] [review] > Seagull device PR > > Good but you still need to fix the aosp_d5103.mk :( (In reply to Alexandre LISSY :gerard-majax from comment #20) > https://github.com/mozilla-b2g/device-sony-aries/commit/ > 0d52244fae3f793b001fb7136b22dfc50f696d44#diff- > 6c3f8c94865d22a0c39c682e4f1811c3L23
Flags: needinfo?(nicolas)
File aosp_d5103.mk modified in case vendor/sony/seagull/seagull-vendor.mk is missing. Rebased.
Flags: needinfo?(nicolas)
Looks all good to me! Thanks!
Looks good to me too, +1 for merge, thank you for your interest in this device Nocolas :)
Hehe, sorry, but https://github.com/mozilla-b2g/device-sony-seagull/pull/1 is done against l-mr1 and not sony-aosp-l
Flags: needinfo?(nicolas)
Attached file Seagull device PR —
Attachment #8694377 - Attachment is obsolete: true
Flags: needinfo?(nicolas)
Attachment #8695860 - Flags: review?(lissyx+mozillians)
Comment on attachment 8695860 [details] [review] Seagull device PR Looks good :)
Attachment #8695860 - Flags: review?(lissyx+mozillians) → review+
verified as all working well by nicolas and adam
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: