Closed
Bug 1221154
Opened 9 years ago
Closed 7 years ago
Use Promise based USSD API
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: pelloux, Assigned: pelloux)
References
Details
Attachments
(1 file)
No description provided.
|
||
Comment 1•9 years ago
|
||
|
||
Updated•9 years ago
|
Comment on attachment 8683128 [details] [review]
[gaia] Phoxygen:bug1221154-dialer-ussd-promise > mozilla-b2g:master
Hi Gabriele, could you review this PR?
Attachment #8683128 -
Flags: review?(gsvelto)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8683128 [details] [review]
[gaia] Phoxygen:bug1221154-dialer-ussd-promise > mozilla-b2g:master
LGTM but please add a unit-test to check that notifySuccess and handleMMIReceived are called appropriately before landing.
Attachment #8683128 -
Flags: review?(gsvelto) → review+
Test added and treeherder tests are all green, so requesting merging.
Keywords: checkin-needed
|
|
||
Comment 5•9 years ago
|
||
Hi Pierre-eric, sorry to remove "checkin-needed" as I realized that I made a mistake in my review for bug 1199141 that I need to ask for another patch correction on gecko side. My apology.
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•