1221173 - Filter button collision

Status: RESOLVED DUPLICATE of bug 1221238

(DevTools :: Inspector, defect)

Description

[masfrand]

Attachment: Capture d’écran 2015-11-03 à 17.29.37.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151103004217

Steps to reproduce:

With inspector element, modify css filter, add a filter and open right panel (predefine filter) 



Actual results:

Buttons close and label unit of filters are in the same position.


Expected results:

need space between close button and unit label

Comment 1

[masfrand]

Watch the attachment file to see this bug.

Comment 2

[Andre Klapper]

Please provide a minimal, self-contained testcase.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This affects all branches from 42 to Nightly (45).

Steps to reproduce:
1. Open a web page. I used https://wiki.mozilla.org/
2. Right click a link.
3. Select 'Inspect Element'.
4. In the CSS rules of the Inspector on the right, click below the items of the group to add a new CSS rule for the group.
5. Type "filter:" and select "unset".
6. Click on the icon for the filter.
7. Select "blur" and press "+".
8. Click the icon to open the saved filter sets.

Comment 4

[Tom Tromey :tromey]

Attachment: make FilterWidget handle "unset", "initial", and "inherit"

Comment 5

[Tom Tromey :tromey]

Comment on attachment 8684989 [details] [diff] [review]
make FilterWidget handle "unset", "initial", and "inherit"

Sigh, wrong bug.

Comment 6

[arni2033]

Attachment: testcase 1 - Bug 1221173 - Filter button collision.htm

(In reply to Sebastian H. [:aryx][:archaeopteryx] from comment #3)
Why have you set 'OS: Mac OS X → All' ?   I don't see this issue on Win7:
> screenshot:   https://dl.dropboxusercontent.com/s/y52ujxg8pyz8o97/screenshot%20-%20Bug%201221173%20-%20Filter%20button%20collision.png?dl=0

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to arni2033 from comment #6)
> Why have you set 'OS: Mac OS X → All' ?   I don't see this issue on Win7:
Because it occurred on all branches on Windows. Now it has been fixed in bug 1221238 on Nightly (45) and Aurora (44).