Closed
Bug 1221187
Opened 9 years ago
Closed 9 years ago
Support changing logging level for Marionette
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: impossibus, Assigned: ato)
References
Details
(Keywords: pi-marionette-runner, pi-marionette-server)
Attachments
(4 files, 1 obsolete file)
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
By default, debug-level log messages get dumped into gecko.log by Marionette. This amounts to quite a long log file. Instead, we'd like info-level messages in gecko.log by default, and we'd like a convenient way to specify the log level via the Marionette test runner, say.
The current workaround (to avoid giant log files for long-running tests) is to set a browser pref: 'marionette.logging': False
Assignee | ||
Updated•9 years ago
|
Keywords: ateam-marionette-runner,
ateam-marionette-server
Assignee | ||
Updated•9 years ago
|
Summary: Set log level for gecko.log → Support changing logging level for Marionette
Assignee | ||
Comment 1•9 years ago
|
||
Only outputting info-level makes sense to me, and has been requested by jgraham in the past (though I cannot find the bug right now).
Assignee | ||
Comment 2•9 years ago
|
||
I would suggest the following:
* Allow marionette.logging to be set to one of the values of the Log.jsm Level enum (https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Log.jsm)
* Default to DEBUG on debug and B2G builds (as we do now)
* Default to INFO for optimised builds
* Log I/O related things to a new sub-logger Marionette.Transport
* Use TRACE for I/O
* Hijack mach’s -v (verbose) flag and use this to override marionette.logging to TRACE
Assignee: nobody → ato
Status: NEW → ASSIGNED
OS: Unspecified → All
Hardware: Unspecified → All
Assignee | ||
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29353/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29353/
Attachment #8703441 -
Flags: review?(MattN+bmo)
Assignee | ||
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29355/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29355/
Attachment #8703442 -
Flags: review?(dburns)
Assignee | ||
Comment 5•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29357/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29357/
Attachment #8703443 -
Flags: review?(dburns)
Assignee | ||
Comment 6•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29359/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29359/
Attachment #8703444 -
Flags: review?(dburns)
Comment 7•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
https://reviewboard.mozilla.org/r/29359/#review26153
Attachment #8703444 -
Flags: review?(dburns)
Comment 8•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
https://reviewboard.mozilla.org/r/29357/#review26151
::: testing/marionette/client/marionette/runner/base.py:267
(Diff revision 1)
> + help='Increase verbosity by including debug- and trace messages.')
Can we add what the numbers are? At the moment we don't give the user any hint what values are legal.
Attachment #8703443 -
Flags: review?(dburns)
Updated•9 years ago
|
Attachment #8703442 -
Flags: review?(dburns)
Comment 9•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
https://reviewboard.mozilla.org/r/29355/#review26149
::: testing/marionette/components/marionettecomponent.js:49
(Diff revision 1)
> + let l = Log.Level.Info;
Change the variable to give a future reader a hint what it is without havinging to search for where it could be instantiated.
::: testing/marionette/components/marionettecomponent.js:59
(Diff revision 1)
> + let s = Services.prefs.getCharPref(LOG_PREF);
what is `s`? A single character variable makes it hard to read what should be in it especially when `s` could be service here
Comment 10•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
https://reviewboard.mozilla.org/r/29359/#review26155
Attachment #8703444 -
Flags: review+
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29353/diff/1-2/
Attachment #8703441 -
Flags: review?(MattN+bmo)
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29353/diff/1-2/
Attachment #8703441 -
Flags: review?(MattN+bmo)
Assignee | ||
Updated•9 years ago
|
Attachment #8703442 -
Flags: review?(dburns)
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29355/diff/1-2/
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/1-2/
Attachment #8703443 -
Flags: review?(dburns)
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/1-2/
Assignee | ||
Comment 16•9 years ago
|
||
I realised in retrospect that a new appender was the wrong solution for filtering log messages because this modifies the internal data structure of the logged messages. Instead I’ve redone the first patch to implement a FilteredFormatter instead, that from a predicate function can tell if the message should be formatted or not.
Assignee | ||
Comment 17•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29355/diff/2-3/
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/2-3/
Assignee | ||
Comment 19•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/2-3/
Assignee | ||
Comment 20•9 years ago
|
||
https://reviewboard.mozilla.org/r/29355/#review26149
> what is `s`? A single character variable makes it hard to read what should be in it especially when `s` could be service here
It’s a string, and also a transitive variable that is consumed on the next line and then goes out of scope. I’m not really sure what to change this to in order to make that clearer.
`preferenceAsString` seems too Java-esque for my taste.
Assignee | ||
Comment 21•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/3-4/
Assignee | ||
Comment 22•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/3-4/
Assignee | ||
Comment 23•9 years ago
|
||
Passing the version keyword to argparse's constructor implicitly adds
-v and --version flags that conflicts with the -v/--verbose flag that
is added in BaseMarionetteArguments.
This removes -v as an alias to --version, which unbreaks testing on try
because it uses runtests.py.
It's perhaps worth mentioning that try uses runtests.py because it does
not (yet) have a full checkout of the source when it runs the tests.
r=dburns
Review commit: https://reviewboard.mozilla.org/r/29703/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29703/
Assignee | ||
Comment 24•9 years ago
|
||
Comment on attachment 8704688 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29703/diff/1-2/
Attachment #8704688 -
Flags: review?(dburns)
Comment 25•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
https://reviewboard.mozilla.org/r/29355/#review26693
::: testing/marionette/components/marionettecomponent.js:59
(Diff revision 3)
> + let s = Services.prefs.getCharPref(LOG_PREF);
we can merge these 2 lines, the variable `s` seems quite meaningless.
Attachment #8703442 -
Flags: review?(dburns) → review+
Comment 26•9 years ago
|
||
Comment on attachment 8704688 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag
https://reviewboard.mozilla.org/r/29703/#review26699
Attachment #8704688 -
Flags: review?(dburns) → review+
Assignee | ||
Comment 27•9 years ago
|
||
Filed bug 1237638 as a follow-up to upload the marionette-packets.log to Treeherder.
Blocks: 1237638
Comment 28•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
https://reviewboard.mozilla.org/r/29357/#review26701
Attachment #8703443 -
Flags: review?(dburns) → review+
Assignee | ||
Comment 29•9 years ago
|
||
I think the try run (https://treeherder.mozilla.org/#/jobs?repo=try&revision=736aef156481) is fine. Tomcat is saying that M2 is a known issue, and I believe we don’t really care about B2G Desktop any longer.
Assignee | ||
Updated•9 years ago
|
Attachment #8703441 -
Flags: review?(MattN+bmo) → review?(markh)
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
https://reviewboard.mozilla.org/r/29353/#review26779
I don't think this is the correct approach for the log module to be taking. Without more context, it appears you should be able to do everything you need without any changes to Log.jsm
::: toolkit/modules/Log.jsm:83
(Diff revision 2)
> + fromString: function(s) {
There are lots of places in our code that do something like this, but they are happy to just do |Log.Level[name]| - it doesn't work if the case of the name is wrong, but that's never been a problem in practice (ie, that's just a typo, like mis-spelling the name would be).
A quick look also didn't show a caller of fromNumber (other than here obviously) - what's the use-case for that?
::: toolkit/modules/Log.jsm:743
(Diff revision 2)
> +function FilteredFormatter(predicate, formatter=null) {
The one FilteredFormatter I could see in the other patches simply checks the level of the message - but this is precisely what the log level is for. Further, if someone uses a FilteredFormatter for this purpose, they lose the ability to use a *real* formatter.
I think that instead of using this, you can simply set the level on the appender itself. Eg, you could have the log itself set to, say, trace, but 2 appenders on the log, one with debug and one with info - so trace messages wouldn't actually be written anywhere even though the log itself has that level. A quick look at that other patch implies that would work OK for you (but it might be necessary to avoid logging directly to a "root" logger as messages get passed up the hierarchy). Something like:
let root = Log.repository.getLogger("Marionette");
root.level = Log.Level.Trace; // "sub" loggers default to this level.
let log = Log.repository.getLogger("Marionette.General");
let iolog = Log.repository.getLogger("Marionette.Transport");
// log everything above provided level to stdout,
let a = new Log.DumpAppender(f);
a.level = level;
log.addAppender(a);
iolog.addAppender(a);
/* the below should work, but maybe consider a different pref specifically for this level,
defaulting to, say, Error
*/
if (level <= Log.Level.Debug) {
iolog.addAppender(new Log.FileAppender(TRANSPORT_LOG));
}
Attachment #8703441 -
Flags: review?(markh)
Assignee | ||
Comment 31•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29353/diff/2-3/
Attachment #8703441 -
Attachment description: MozReview Request: Bug 1221187: toolkit/modules/Log.jsm: Add lookup functions for levels → MozReview Request: Bug 1221187: testing/marionette: Allow setting logging level from preference
Attachment #8703441 -
Flags: review?(markh)
Assignee | ||
Updated•9 years ago
|
Attachment #8703442 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette: Allow setting logging level from preference → MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output
Assignee | ||
Comment 32•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29355/diff/3-4/
Assignee | ||
Comment 33•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/4-5/
Attachment #8703443 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output → MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults
Assignee | ||
Comment 34•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/4-5/
Attachment #8703444 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults → MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag
Assignee | ||
Updated•9 years ago
|
Attachment #8704688 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8703441 -
Flags: review?(markh) → review?(dburns)
Assignee | ||
Comment 35•9 years ago
|
||
Because the changeset has disappeared from MozReview, I’ll comment briefly here instead.
First of all, thank you for your quick and thoughtful review. It was much appreciated.
(In reply to Mark Hammond [:markh] from comment #30)
> ::: toolkit/modules/Log.jsm:83
> (Diff revision 2)
> > + fromString: function(s) {
>
> There are lots of places in our code that do something like this, but they
> are happy to just do |Log.Level[name]| - it doesn't work if the case of the
> name is wrong, but that's never been a problem in practice (ie, that's just
> a typo, like mis-spelling the name would be).
The difference in this case is that the input comes from unreliable sources externally of Gecko in the form of a string preference. Anyway, I see your point and I didn’t think about using the Log.Level enum as a string lookup. I can perform the normalisation myself.
> A quick look also didn't show a caller of fromNumber (other than here
> obviously) - what's the use-case for that?
That can be dropped.
> ::: toolkit/modules/Log.jsm:743
> (Diff revision 2)
> > +function FilteredFormatter(predicate, formatter=null) {
>
> The one FilteredFormatter I could see in the other patches simply checks the
> level of the message - but this is precisely what the log level is for.
> Further, if someone uses a FilteredFormatter for this purpose, they lose the
> ability to use a *real* formatter.
>
> I think that instead of using this, you can simply set the level on the
> appender itself. Eg, you could have the log itself set to, say, trace, but 2
> appenders on the log, one with debug and one with info - so trace messages
> wouldn't actually be written anywhere even though the log itself has that
> level. A quick look at that other patch implies that would work OK for you
> (but it might be necessary to avoid logging directly to a "root" logger as
> messages get passed up the hierarchy). Something like:
Oh I see, thanks for explaining how inherited loggers work. That part was a bit of a mystery.
I have now reviewed my approach and opted for a simple solution with just one logger and the default stdout Gecko log. This renders the first patch to Log.jsm unnecessary, so I have dropped it.
(In reply to Andreas Tolfsen (:ato) from comment #35)
> The difference in this case is that the input comes from unreliable sources
> externally of Gecko in the form of a string preference.
FTR, that's exactly what all those other references I was discussing do - read a pref value and attempt to use it directly as a level string without normalization. Preferences really aren't "unreliable", in that we typically trust preferences (within reason) because changing various preferences could do nasty things (think the "security.turn_off_all_security_so_that_viruses_can_take_over_this_computer" pref :).
eg,
https://dxr.mozilla.org/mozilla-central/source/browser/experiments/Experiments.jsm#127
https://dxr.mozilla.org/mozilla-central/source/browser/modules/SelfSupportBackend.jsm#169
https://dxr.mozilla.org/mozilla-central/source/services/common/hawkrequest.js#148
https://dxr.mozilla.org/mozilla-central/source/services/fxaccounts/FxAccountsCommon.js#47
etc
> I can perform the normalisation myself.
There's no harm in that, but also no real value I can see.
Assignee | ||
Comment 37•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29353/diff/3-4/
Assignee | ||
Comment 38•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29355/diff/4-5/
Assignee | ||
Comment 39•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/5-6/
Assignee | ||
Comment 40•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/5-6/
Assignee | ||
Comment 41•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29353/diff/4-5/
Attachment #8703441 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette: Allow setting logging level from preference → MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r=automatedtester
Assignee | ||
Comment 42•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29355/diff/5-6/
Attachment #8703442 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output → MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r=automatedtester
Assignee | ||
Comment 43•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/6-7/
Attachment #8703443 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults → MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r=automatedtester
Assignee | ||
Comment 44•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/6-7/
Attachment #8703444 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag → MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r=automatedtester
Assignee | ||
Comment 45•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29353/diff/5-6/
Attachment #8703441 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r=automatedtester → MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Assignee | ||
Comment 46•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29355/diff/6-7/
Attachment #8703442 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r=automatedtester → MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Assignee | ||
Comment 47•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/7-8/
Attachment #8703443 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r=automatedtester → MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Assignee | ||
Comment 48•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/7-8/
Attachment #8703444 -
Attachment description: MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r=automatedtester → MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Comment 49•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
https://reviewboard.mozilla.org/r/29353/#review27095
Attachment #8703441 -
Flags: review?(dburns) → review+
Comment 50•9 years ago
|
||
Assignee | ||
Comment 51•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29353/diff/6-7/
Assignee | ||
Comment 52•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29355/diff/7-8/
Assignee | ||
Comment 53•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/8-9/
Assignee | ||
Comment 54•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/8-9/
Assignee | ||
Comment 55•9 years ago
|
||
Comment on attachment 8703441 [details]
MozReview Request: Bug 1221187: testing/marionette: Set log level from preference; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29353/diff/7-8/
Assignee | ||
Comment 56•9 years ago
|
||
Comment on attachment 8703442 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Add -v flag for trace logging output; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29355/diff/8-9/
Assignee | ||
Comment 57•9 years ago
|
||
Comment on attachment 8703443 [details]
MozReview Request: Bug 1221187: testing/marionette: Adjust log levels to match new defaults; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29357/diff/9-10/
Assignee | ||
Comment 58•9 years ago
|
||
Comment on attachment 8703444 [details]
MozReview Request: Bug 1221187: testing/marionette/client: Explicitly define --version flag; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29359/diff/9-10/
Comment 59•9 years ago
|
||
Comment 60•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4a64a53b9075
https://hg.mozilla.org/mozilla-central/rev/8f27ebb8c93d
https://hg.mozilla.org/mozilla-central/rev/8e77b64f8169
https://hg.mozilla.org/mozilla-central/rev/0dbc316b2160
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•