1221386 - checksums failing for 43.0b1

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

17:32:47     INFO - #####
17:32:47     INFO - ##### Running upload step.
17:32:47     INFO - #####
17:32:47     INFO - Running main action method: upload
One (and only one of UPLOAD_PATH or UPLOAD_TO_TEMP must be defined.

The problem is that we're passing path="dummy" and upload_to_temp_dir=True to http://hg.mozilla.org/releases/mozilla-beta/file/6e78daec52af/build/upload.py#l190
at http://hg.mozilla.org/releases/mozilla-beta/file/6e78daec52af/testing/mozharness/scripts/release/generate-checksums.py#l243

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [gecko] Stop passing "dummy"

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

The error above was for Fennec, but we'll hit it for Firefox too so lets land on both relbranches and retag. It'll need to go on m-c and m-a eventually to.

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8682885 [details] [diff] [review]
[gecko] Stop passing "dummy"

Review of attachment 8682885 [details] [diff] [review]:
-----------------------------------------------------------------

:( more uplift fun.

I think None might not be an acceptable value as we will still treat it like a string: https://hg.mozilla.org/mozilla-central/rev/b41a88070b1b#l1.81

iiuc, we have to either tweak UploadFiles() a lot more or we pass an empty string.

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8682885 [details] [diff] [review]
[gecko] Stop passing "dummy"

Review of attachment 8682885 [details] [diff] [review]:
-----------------------------------------------------------------

oh sorry, I guess we could do this because we set path to upload_to_temp_dir just before that: https://dxr.mozilla.org/mozilla-central/source/build/upload.py#209

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8682885 [details] [diff] [review]
[gecko] Stop passing "dummy"

https://hg.mozilla.org/releases/mozilla-beta/rev/d5bb596f28cd (MOBILE430b1_2015110305_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-beta/rev/c60ce6046bc7 (GECKO430b1_2015110305_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-beta/rev/9211dd55954e (default)
https://hg.mozilla.org/releases/mozilla-aurora/rev/3b6702f55a19
https://hg.mozilla.org/integration/mozilla-inbound/rev/717b8114f16a

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Fixed in 43.0 and later, 42 is unaffected.

Comment 7

[Jordan Lund (:jlund)]

will let the m-c land close this bug out

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/717b8114f16a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3b6702f55a19