Closed
Bug 1221386
Opened 9 years ago
Closed 9 years ago
checksums failing for 43.0b1
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(firefox43 fixed, firefox44 fixed, firefox45 fixed, b2g-v2.5 fixed)
People
(Reporter: nthomas, Assigned: nthomas)
References
Details
Attachments
(1 file)
978 bytes,
patch
|
jlund
:
review+
nthomas
:
checked-in+
|
Details | Diff | Splinter Review |
17:32:47 INFO - #####
17:32:47 INFO - ##### Running upload step.
17:32:47 INFO - #####
17:32:47 INFO - Running main action method: upload
One (and only one of UPLOAD_PATH or UPLOAD_TO_TEMP must be defined.
The problem is that we're passing path="dummy" and upload_to_temp_dir=True to http://hg.mozilla.org/releases/mozilla-beta/file/6e78daec52af/build/upload.py#l190
at http://hg.mozilla.org/releases/mozilla-beta/file/6e78daec52af/testing/mozharness/scripts/release/generate-checksums.py#l243
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8682885 -
Flags: review?(jlund)
Assignee | ||
Comment 2•9 years ago
|
||
The error above was for Fennec, but we'll hit it for Firefox too so lets land on both relbranches and retag. It'll need to go on m-c and m-a eventually to.
Comment 3•9 years ago
|
||
Comment on attachment 8682885 [details] [diff] [review]
[gecko] Stop passing "dummy"
Review of attachment 8682885 [details] [diff] [review]:
-----------------------------------------------------------------
:( more uplift fun.
I think None might not be an acceptable value as we will still treat it like a string: https://hg.mozilla.org/mozilla-central/rev/b41a88070b1b#l1.81
iiuc, we have to either tweak UploadFiles() a lot more or we pass an empty string.
Comment 4•9 years ago
|
||
Comment on attachment 8682885 [details] [diff] [review]
[gecko] Stop passing "dummy"
Review of attachment 8682885 [details] [diff] [review]:
-----------------------------------------------------------------
oh sorry, I guess we could do this because we set path to upload_to_temp_dir just before that: https://dxr.mozilla.org/mozilla-central/source/build/upload.py#209
Attachment #8682885 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8682885 [details] [diff] [review]
[gecko] Stop passing "dummy"
https://hg.mozilla.org/releases/mozilla-beta/rev/d5bb596f28cd (MOBILE430b1_2015110305_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-beta/rev/c60ce6046bc7 (GECKO430b1_2015110305_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-beta/rev/9211dd55954e (default)
https://hg.mozilla.org/releases/mozilla-aurora/rev/3b6702f55a19
https://hg.mozilla.org/integration/mozilla-inbound/rev/717b8114f16a
Attachment #8682885 -
Flags: checked-in+
Assignee | ||
Comment 6•9 years ago
|
||
Fixed in 43.0 and later, 42 is unaffected.
Comment 7•9 years ago
|
||
will let the m-c land close this bug out
status-firefox43:
--- → fixed
status-firefox44:
--- → fixed
Comment 8•9 years ago
|
||
bugherder |
Comment 9•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•