122145 - File->New Navigator Window does not work from page source window

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[André Dahlqvist]

[Build-ID: 2002-01-25-15 from the 0.9.8 branch]

You cannot launch a new navigator window from the Page Source window by using
File->New Navigator Window. It works however if you do File->New->Navigator
Window in the same window.

Reproducable: always
Steps to reproduce:
1) Go to a page and click on View-Page Source
2) Select File->New Navigator Window

Result: no new window is opened.

As I mentioned above, File->New->New Navigator Window works, so the fix
shouldn't be hard I presume.

Comment 1

[Luke Koleszar]

I also see this on 0.9.8 branch (2002012705 WinME) and 0.9.7 
OS -> All

Comment 2

[Peter Trudelle]

os->all

Comment 3

[André Dahlqvist]

This seams to be a long-standing bug. I tried a few builds between present and
back to 2001-12-26-08 and they were all broken. Then I tried 0.9.6 (!) and that
was also broken. Does anyone remember a milestone that this worked in?

Comment 4

[André Dahlqvist]

0.9.5 was okay. There are only three checkins to viewSource.xul and viewsource.js
between these releases, so it should be easy to find the guilty part. Here are the
checkins:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=view%5BsS%5Dource&filetype=regexp&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=10%2F12%2F2001&maxdate=11%2F20%2F2001&cvsroot=%2Fcvsroot

CC'ing Blake Ross first since I think this is his fault:-)

Comment 5

[Peter Trudelle]

->blaker?

Comment 6

[sairuh (rarely reading bugmail)]

->doronr...

Comment 7

[Doron Rosenberg (IBM)]

More likely someone changed something in navigatorOverlay and forgot to change
viewsource.xul.  Need to get my navOverlay splitt in so this won't happen.

Comment 8

[Doron Rosenberg (IBM)]

Attachment: patch

fixes the issue (observes -> command)

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 67460 [details] [diff] [review]
patch

r=bzbarsky

Comment 10

[Doron Rosenberg (IBM)]

cc: alecf for sr, unless blake does it first.

Comment 11

[Alec Flett]

Comment on attachment 67460 [details] [diff] [review]
patch

sr=alecf

Comment 12

[Patty Mac]

nominating nsbeta1 because it should open new Navigation window from page source
window.

Comment 13

[Doron Rosenberg (IBM)]

bz, could you check this in for me?

Comment 14

[Boris Zbarsky [:bzbarsky]]

Sure thing, soon as you get a=.  :)

Comment 15

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.9

Comment 16

[Boris Zbarsky [:bzbarsky]]

checked in on trunk for 0.9.9

Comment 17

[André Dahlqvist]

Verified fixed with 2002-03-24-19 on Linux.