1221485 - Setting &count=X above the max count should not result in an HTTP 200

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, defect, P3)

Description

[Ed Morley [:emorley]]

eg:
treeherder.mozilla.org/api/project/mozilla-inbound/resultset/?count=100000
treeherder.mozilla.org/api/project/mozilla-inbound/jobs/?count=10000&result_set_id=22477&return_type=list

Also, I think we should think about reducing some of the counts. 1000 might be too high for resultset etc.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:1221485 > mozilla:master

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8762909 [details] [review]
[treeherder] KWierso:1221485 > mozilla:master

Not sure if this is all that's needed to fix this bug. Haven't reduced the max count from 1000 to anything lower yet, as I don't know I'm the best person to decide the api limit. (do we need a dba or something to find the best limit?)


This should also fix bug 1190477, yes?

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #2)
> This should also fix bug 1190477, yes?

Or, I guess that's about more than just the resultset api...

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8762909 [details] [review]
[treeherder] KWierso:1221485 > mozilla:master

Looks good with the formatting comment.  But would you be able to do the same change to support the ``limit`` param as Ed suggested in bug 1203551 here?

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/73d0c75ee6272ac3aa3ebb07ed6d7521dcbdd322
Bug 1221485 - Don't allow count to exceed the upper limit on resultsets (#1593) r=camd

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Went ahead and landed without the switch to DRF since this is using Datasource which would be a much larger change than this bug needs.