1221534 - Move "Clear private data now" option from General submenu on Tablet

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Nexus 9 (Android 6.0)

Steps to reproduce:
1. Go to Menu -> Settings -> General

Actual results:
- "Clear private data now" option is displayed in "General" submenu

Expected results:
- Move "Clear private data now" option from this submenu

Comment 1

[:Margaret Leibovic]

I'm not sure where we landed on this... as I mentioned in bug 1216257, on tablets, our "top level" settings items need to correspond to panes on the right side of the screen. So for top-level items like "Sync", which doesn't have a sub-category, we've moved that into "General", so it shows up when the user first enters settings.

I did the same thing for "Clear private data", but maybe that doesn't make as much sense, since it would fit much better under "Privacy" than "General".

Our options are:

1) Leave "Clear private data" in "General" on tablets
2) Move "Clear private data" to "Privacy" on tablets
3) Create a new category on the left side of the screen, with an option to clear private data displayed on the right side

I'm leaning towards #2 because that seems simplest.

Anthony and Gemma, what do you think?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think moving it into Privacy is OK. But I worry about confusing the user with the inconsistency. 

Given that our "Clear private data" button opens a dialog on mobile, could we just leave this button in the left column and trigger the dialog when it's pressed?

Comment 3

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #2)
> I think moving it into Privacy is OK. But I worry about confusing the user
> with the inconsistency. 
> 
> Given that our "Clear private data" button opens a dialog on mobile, could
> we just leave this button in the left column and trigger the dialog when
> it's pressed?

There's a way to intercept clicks on the headers, but I'm having a hard time finding a way to have that open the dialog that comes up when you select the normal "Clear Private Data" preference, since these header items on the left are different than preference items that appear in lists on the right.

How would you feel about a "Clear Private Data" item that open a panel on the right with a single item for clearing private data?

I think we need to come up with some solution that doesn't involve clicking on headers on the left side of the screen doing anything other than changing the contents on the right side.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Sure, that's an OK compromise to me!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Stealing.. :)

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1221534 - Add "Clear private data" sub menu on tablets. r?margaret

Bug 1221534 - Add "Clear private data" sub menu on tablets. r?margaret

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: clear_private_data.png

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8694165 [details]
clear_private_data.png

WFM! 

We could say "Clear now" instead but I'm not gonna block on that since I'm also not sure how difficult that would be to do ONLY for Tablets.

Comment 9

[:Margaret Leibovic]

Comment on attachment 8694164 [details]
MozReview Request: Bug 1221534 - Add "Clear private data" sub menu on tablets. r?margaret

https://reviewboard.mozilla.org/r/26677/#review24175

::: mobile/android/base/resources/xml-v11/preferences_privacy_clear_tablet.xml:9
(Diff revision 1)
> +        android:title="@string/pref_clear_private_data_now"

Since this is a tablet-only resource, we could implement antlam's suggestion for a different title here.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/469b3454bfbd5fe46bf9292463248ac9419adc78
Bug 1221534 - Add "Clear private data" sub menu on tablets. r=margaret

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Landed with antlam's suggestion added.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/469b3454bfbd

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-12-07-15-44-28.png

Verified as fixed using:
Device: Sony Xperia Z2 (Android 5.0.2)
Build: Firefox for Android 45.0a1 (2015-12-06)