Closed Bug 1221534 Opened 4 years ago Closed 4 years ago

Move "Clear private data now" option from General submenu on Tablet

Categories

(Firefox for Android :: Settings and Preferences, defect)

45 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- verified

People

(Reporter: TeoVermesan, Assigned: sebastian)

References

Details

Attachments

(3 files)

Tested with:
Device: Nexus 9 (Android 6.0)

Steps to reproduce:
1. Go to Menu -> Settings -> General

Actual results:
- "Clear private data now" option is displayed in "General" submenu

Expected results:
- Move "Clear private data now" option from this submenu
I'm not sure where we landed on this... as I mentioned in bug 1216257, on tablets, our "top level" settings items need to correspond to panes on the right side of the screen. So for top-level items like "Sync", which doesn't have a sub-category, we've moved that into "General", so it shows up when the user first enters settings.

I did the same thing for "Clear private data", but maybe that doesn't make as much sense, since it would fit much better under "Privacy" than "General".

Our options are:

1) Leave "Clear private data" in "General" on tablets
2) Move "Clear private data" to "Privacy" on tablets
3) Create a new category on the left side of the screen, with an option to clear private data displayed on the right side

I'm leaning towards #2 because that seems simplest.

Anthony and Gemma, what do you think?
Flags: needinfo?(gpetrie)
Flags: needinfo?(alam)
I think moving it into Privacy is OK. But I worry about confusing the user with the inconsistency. 

Given that our "Clear private data" button opens a dialog on mobile, could we just leave this button in the left column and trigger the dialog when it's pressed?
Flags: needinfo?(alam) → needinfo?(margaret.leibovic)
(In reply to Anthony Lam (:antlam) from comment #2)
> I think moving it into Privacy is OK. But I worry about confusing the user
> with the inconsistency. 
> 
> Given that our "Clear private data" button opens a dialog on mobile, could
> we just leave this button in the left column and trigger the dialog when
> it's pressed?

There's a way to intercept clicks on the headers, but I'm having a hard time finding a way to have that open the dialog that comes up when you select the normal "Clear Private Data" preference, since these header items on the left are different than preference items that appear in lists on the right.

How would you feel about a "Clear Private Data" item that open a panel on the right with a single item for clearing private data?

I think we need to come up with some solution that doesn't involve clicking on headers on the left side of the screen doing anything other than changing the contents on the right side.
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(gpetrie)
Flags: needinfo?(alam)
Sure, that's an OK compromise to me!
Flags: needinfo?(alam)
Stealing.. :)
Assignee: margaret.leibovic → s.kaspari
Status: NEW → ASSIGNED
Bug 1221534 - Add "Clear private data" sub menu on tablets. r?margaret
Attachment #8694164 - Flags: review?(margaret.leibovic)
Attached image clear_private_data.png
Attachment #8694165 - Flags: feedback?(alam)
Comment on attachment 8694165 [details]
clear_private_data.png

WFM! 

We could say "Clear now" instead but I'm not gonna block on that since I'm also not sure how difficult that would be to do ONLY for Tablets.
Attachment #8694165 - Flags: feedback?(alam) → feedback+
Comment on attachment 8694164 [details]
MozReview Request: Bug 1221534 - Add "Clear private data" sub menu on tablets. r?margaret

https://reviewboard.mozilla.org/r/26677/#review24175

::: mobile/android/base/resources/xml-v11/preferences_privacy_clear_tablet.xml:9
(Diff revision 1)
> +        android:title="@string/pref_clear_private_data_now"

Since this is a tablet-only resource, we could implement antlam's suggestion for a different title here.
Attachment #8694164 - Flags: review?(margaret.leibovic) → review+
Landed with antlam's suggestion added.
https://hg.mozilla.org/mozilla-central/rev/469b3454bfbd
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Verified as fixed using:
Device: Sony Xperia Z2 (Android 5.0.2)
Build: Firefox for Android 45.0a1 (2015-12-06)
You need to log in before you can comment on or make changes to this bug.