1221595 - Tapping Edit on the LoginsDetailsViewController should enable editing of title, username, password, website text fields

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

Attachment: Screenshot 2015-11-04 11.37.09.png

Additional requirements:

* Leaving edit mode without hitting done shouldn't persist any changes made
* Entering edit mode updates the title labels for the fields to gray from blue
* Selecting done saves changes to database and should be queued for syncing
* Leaving edit mode disables text input and returns to a readonly view of the screen.

Comment 1

[Aaron Train [:aaronmt]]

* Will entering edit mode unmask the current password? 

* Is there any way to unmask the current password without requiring edit mode?

Comment 2

[Stephan Leroux [:sleroux]]

* Yes, when the password field is selected, the password becomes unmasked.

* Long pressing the password row/text field will show the text selection options which includes a 'Reveal' option.

Comment 3

[Robin Andersen [:tecgirl]]

:sleroux

I'm not sure where you're at with this (so forgive me if WIP), but I noticed that in 'Edit' mode, the selection circle appears and are selectable. I'm also not able to edit the entries or copy the username.

Comment 4

[Stephan Leroux [:sleroux]]

I think you might have been looking at the wrong branch (the select all/delete branch) since that's where the checkmark code lives.

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1406

Flagged both rnewman and bnicholson for database/UI code respectively.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8704691 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1406

Comments on the PR.

Comment 7

[Robin Andersen [:tecgirl]]

Comment on attachment 8704691 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1406

LG except the editable fields (username/password) should indent and headers turn grey when in 'Edit' mode.

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8704691 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1406

LGTM

Comment 9

[Stephan Leroux [:sleroux]]

Comment on attachment 8704691 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1406

I've updated the PR to include the indent and header color change.

Comment 10

[Stephan Leroux [:sleroux]]

Comment on attachment 8704691 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1406

https://github.com/mozilla/firefox-ios/commit/0e62890e4b670a3fd52e99c0c89685f29091f210 for the code change if you're interested.

Comment 11

[Brian Nicholson (:bnicholson)]

Comment on attachment 8704691 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1406

Updated patch looks sane to me.

Comment 12

[Stephan Leroux [:sleroux]]

Comment on attachment 8704691 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1406

Oops forgot to tag you Robin.

Comment 13

[Stephan Leroux [:sleroux]]

master f46afa4ca9be3b0d434a0f6e2d7dad255c9296ef