Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h

RESOLVED FIXED in Firefox 45

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Trunk
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
A while ago I commented all these pretty well in jsapi.h. But I missed GetPropertyKeys because it was hiding in jsfriendapi.h.

Also I copied and pasted some text from jsobj.h to jsapi.h; having two copies is bad, so let's delete from jsobj.h.
(Assignee)

Comment 1

3 years ago
Created attachment 8683148 [details] [diff] [review]
Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h
Attachment #8683148 - Flags: review?(efaustbmo)
(Assignee)

Updated

3 years ago
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED

Comment 2

3 years ago
Comment on attachment 8683148 [details] [diff] [review]
Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h

Review of attachment 8683148 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsfriendapi.h
@@ +953,5 @@
> + *     JSITER_SYMBOLSONLY - Exclude non-symbol property keys.
> + *
> + * This is the closest C++ API we have to `Reflect.ownKeys(obj)`, or
> + * equivalently, the ES6 [[OwnPropertyKeys]] internal method. Pass
> + * `JSITER_OWNONLY | JSITER_HIDDEN | JSITER_SYMBOLS` as flags to get

Too bad we don't expose a JSITER_OWNKEYS that's an |'d mask
Attachment #8683148 - Flags: review?(efaustbmo) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e628091c0bae632ad9f34b9d6b6570c48fa77fc5
Bug 1221600 - Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h. r=efaust.

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e628091c0bae
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.