1221600 - Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

A while ago I commented all these pretty well in jsapi.h. But I missed GetPropertyKeys because it was hiding in jsfriendapi.h.

Also I copied and pasted some text from jsobj.h to jsapi.h; having two copies is bad, so let's delete from jsobj.h.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h

Comment 2

[Eric Faust [:efaust]]

Comment on attachment 8683148 [details] [diff] [review]
Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h

Review of attachment 8683148 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsfriendapi.h
@@ +953,5 @@
> + *     JSITER_SYMBOLSONLY - Exclude non-symbol property keys.
> + *
> + * This is the closest C++ API we have to `Reflect.ownKeys(obj)`, or
> + * equivalently, the ES6 [[OwnPropertyKeys]] internal method. Pass
> + * `JSITER_OWNONLY | JSITER_HIDDEN | JSITER_SYMBOLS` as flags to get

Too bad we don't expose a JSITER_OWNKEYS that's an |'d mask

Comment 3

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e628091c0bae632ad9f34b9d6b6570c48fa77fc5
Bug 1221600 - Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h. r=efaust.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e628091c0bae