Closed Bug 1221600 Opened 5 years ago Closed 4 years ago

Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

A while ago I commented all these pretty well in jsapi.h. But I missed GetPropertyKeys because it was hiding in jsfriendapi.h.

Also I copied and pasted some text from jsobj.h to jsapi.h; having two copies is bad, so let's delete from jsobj.h.
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Comment on attachment 8683148 [details] [diff] [review]
Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h

Review of attachment 8683148 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsfriendapi.h
@@ +953,5 @@
> + *     JSITER_SYMBOLSONLY - Exclude non-symbol property keys.
> + *
> + * This is the closest C++ API we have to `Reflect.ownKeys(obj)`, or
> + * equivalently, the ES6 [[OwnPropertyKeys]] internal method. Pass
> + * `JSITER_OWNONLY | JSITER_HIDDEN | JSITER_SYMBOLS` as flags to get

Too bad we don't expose a JSITER_OWNKEYS that's an |'d mask
Attachment #8683148 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e628091c0bae632ad9f34b9d6b6570c48fa77fc5
Bug 1221600 - Tweak comments about standard internal methods in jsobj.h, jsfriendapi.h. r=efaust.
https://hg.mozilla.org/mozilla-central/rev/e628091c0bae
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.