Closed Bug 1221610 Opened 7 years ago Closed 7 years ago

Typedef nsIntMargin to gfx::IntMargin

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

nsIntMargin and gfx::IntMargin are equivalent, but currently are distinct types. This distinction can be removed.
This introduces a difference between nsMargin and nsIntMargin, which isn't
great, but it also reduces the size of gfx2DGlue.h which I figure is more
important.
Attachment #8683158 - Flags: review?(jmuizelaar)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8683158 [details] [diff] [review]
Typedef nsIntMargin to gfx::IntMargin

Review of attachment 8683158 [details] [diff] [review]:
-----------------------------------------------------------------

What's the difference that it introduces?
Attachment #8683158 - Flags: review?(jmuizelaar) → review+
> What's the difference that it introduces?

Sorry for being unclear: both nsMargin and nsIntMargin used to have very similar definitions in nsMargin.h, but now nsIntMargin is typedef'd to a different type, whereas nsMargin keeps the old definition. Not a big deal.
Just as I was about to push my patch I discovered that Botond had done exactly the same thing in bug 1220898! Except he didn't remove ToIntMargin(), so I landed that remnant.
https://hg.mozilla.org/mozilla-central/rev/0135c32a720c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.