1221610 - Typedef nsIntMargin to gfx::IntMargin

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

nsIntMargin and gfx::IntMargin are equivalent, but currently are distinct types. This distinction can be removed.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Typedef nsIntMargin to gfx::IntMargin

This introduces a difference between nsMargin and nsIntMargin, which isn't
great, but it also reduces the size of gfx2DGlue.h which I figure is more
important.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8683158 [details] [diff] [review]
Typedef nsIntMargin to gfx::IntMargin

Review of attachment 8683158 [details] [diff] [review]:
-----------------------------------------------------------------

What's the difference that it introduces?

Comment 3

[Nicholas Nethercote [inactive]]

> What's the difference that it introduces?

Sorry for being unclear: both nsMargin and nsIntMargin used to have very similar definitions in nsMargin.h, but now nsIntMargin is typedef'd to a different type, whereas nsMargin keeps the old definition. Not a big deal.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0135c32a720c4f5460e5201d3da7b47b5e0f6657
Bug 1221610 - Remove ToIntMargin(). r=jrmuizel.

Comment 5

[Nicholas Nethercote [inactive]]

Just as I was about to push my patch I discovered that Botond had done exactly the same thing in bug 1220898! Except he didn't remove ToIntMargin(), so I landed that remnant.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0135c32a720c