Closed Bug 1221679 Opened 6 years ago Closed 6 years ago

Changing language on phone will update language settings page title with "General"

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

All
Android
defect
Not set
normal

Tracking

(firefox45 fixed, fennec45+)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed
fennec 45+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

(Keywords: regression)

Attachments

(1 file)

Sigh, in fixing the tablet situation, I seem to have busted the phone situation...
Told ya :P
Status: NEW → ASSIGNED
tracking-fennec: --- → ?
OS: Unspecified → Android
Hardware: Unspecified → All
Version: Firefox 35 → Trunk
tracking-fennec: ? → 45+
Bug 1221679 - Properly update settings header on locale change. r=liuche
Attachment #8684378 - Flags: review?(liuche)
I tested this on a phone and a tablet, and in both cases the right thing happened, but they're both running Android 6.0... I don't have an old device to test on. Chenxia, maybe you can try this with a device in SF?

This patch looks like it does a lot, but really I decided to do some clean-up of unused and unnecessary logic:

1) I don't know why we made an additional `updateTitle` signature... `setTitle` already has 2 signatures we can use directly.

2) `updateTitleForPrefsResource` is only called for pre-HC devices, so we can remove logic in there that would only be called on HC+.
Attachment #8684378 - Flags: review?(liuche) → review+
Comment on attachment 8684378 [details]
MozReview Request: Bug 1221679 - Properly update settings header on locale change. r=liuche

https://reviewboard.mozilla.org/r/24547/#review22279

Nice - I tried this out and it works fine. Removing the updateTitle also makes sense to me!
https://hg.mozilla.org/integration/fx-team/rev/d9bc1c0ff110ee922a3ab6aa20baf6809095a5c8
Bug 1221679 - Properly update settings header on locale change. r=liuche
https://hg.mozilla.org/mozilla-central/rev/d9bc1c0ff110
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.