1221679 - Changing language on phone will update language settings page title with "General"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

Sigh, in fixing the tablet situation, I seem to have busted the phone situation...

Comment 1

[Richard Newman [:rnewman]]

Told ya :P

Comment 2

[:Margaret Leibovic]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e359c52b466

Comment 3

[:Margaret Leibovic]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=805649f6fbba

Comment 4

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1221679 - Properly update settings header on locale change. r=liuche

Bug 1221679 - Properly update settings header on locale change. r=liuche

Comment 5

[:Margaret Leibovic]

I tested this on a phone and a tablet, and in both cases the right thing happened, but they're both running Android 6.0... I don't have an old device to test on. Chenxia, maybe you can try this with a device in SF?

This patch looks like it does a lot, but really I decided to do some clean-up of unused and unnecessary logic:

1) I don't know why we made an additional `updateTitle` signature... `setTitle` already has 2 signatures we can use directly.

2) `updateTitleForPrefsResource` is only called for pre-HC devices, so we can remove logic in there that would only be called on HC+.

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8684378 [details]
MozReview Request: Bug 1221679 - Properly update settings header on locale change. r=liuche

https://reviewboard.mozilla.org/r/24547/#review22279

Nice - I tried this out and it works fine. Removing the updateTitle also makes sense to me!

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/d9bc1c0ff110ee922a3ab6aa20baf6809095a5c8
Bug 1221679 - Properly update settings header on locale change. r=liuche

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d9bc1c0ff110