If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Create custom UIMenuItem action for revealing the password

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sleroux, Assigned: sleroux, Mentored)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios2.0+)

Details

(Whiteboard: [good first bug][needstrings])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
By default, the password field in the login detail view will be password-ized with dots. When the selects it, we should display a copy and reveal option that shows the password in plain text. Looks like we can add a custom item to the selection menu using UIMenuController

http://nshipster.com/uimenucontroller/

https://developer.apple.com/library/prerelease/ios/documentation/iPhone/Reference/UIMenuController_Class/index.html
(Assignee)

Comment 1

2 years ago
Created attachment 8683246 [details]
Screenshot 2015-11-04 14.09.41.png
(Assignee)

Updated

2 years ago
Blocks: 1221594
No longer depends on: 1221594
(Assignee)

Updated

2 years ago
Mentor: sleroux@mozilla.com
Whiteboard: [good first bug]
(Assignee)

Updated

2 years ago
Whiteboard: [good first bug] → [good first bug][needstrings]
(Assignee)

Comment 2

2 years ago
Created attachment 8701143 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1382

Flagging bnicholson since Emily's on PTO
Attachment #8701143 - Flags: review?(etoop)
Attachment #8701143 - Flags: review?(bnicholson)
(Assignee)

Comment 3

2 years ago
Note: This PR also includes https://bugzilla.mozilla.org/show_bug.cgi?id=1221693. Was easier to do it all in one go.
(Assignee)

Updated

2 years ago
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 years ago
Comment on attachment 8701143 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1382

:tecgirl I forgot to flag you for a UI review on the login detail screen. You can check it as part of this if you want as this includes the menu actions (no editing though).
Attachment #8701143 - Flags: ui-review?(randersen)
Attachment #8701143 - Flags: ui-review?(randersen) → ui-review+
Comment on attachment 8701143 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1382

Looks good! Just a few notes in the PR.
Attachment #8701143 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 6

2 years ago
Thanks for the double pass on this. I've fixed up the nits and included the settings delegate (with test!) to this PR as well.
(Assignee)

Comment 7

2 years ago
Landed

master b98103973b5ccfd9b2008eb29bb04de54f862c73
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Attachment #8701143 - Flags: review?(etoop)
You need to log in before you can comment on or make changes to this bug.