1221706 - Create custom UITableViewCell class for displaying an optional logo, header and input field

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

Attachment: celllayouts.png

Across the login management screens, we use a similarly structured cell for displaying login summaries, input fields, and titles. We need to create a custom subclass of UITableViewCell that will handle the various layouts needed in each case.

Usages:

1. Login summary view (header + logo + text)
2. Input fields (header + text)
3. Login detail title (logo + text)

Comment 1

[Stephan Leroux [:sleroux]]

Do you have the font sizes/color/margins for this layout?

Comment 2

[Stephan Leroux [:sleroux]]

Also, do you have a copy of the default firefox icon? I have a version in the app we use for the footer but downscaling it to fit makes it look grainy.

Comment 3

[Stephan Leroux [:sleroux]]

One more thing! I've started to use FBSnapshotTestCase for saving reference images so we can run tests on the layout without having to run the app. Also helps in reviewing UI changes :)

https://github.com/mozilla/firefox-ios/commit/adb53406a59c6ce38c2155be8e0acdc5c7b45d88

Comment 4

[Robin Andersen [:tecgirl]]

(In reply to Stephan Leroux [:sleroux] from comment #1)
> Do you have the font sizes/color/margins for this layout?

Yes, I'll add the spec and the grey default fox logo. Great to hear about FBSnapshotTestCase!

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1336

Comment 6

[Emily Toop (:fluffyemily)]

Comment on attachment 8695398 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1336

Just one small nit switching the ref tests to `recordMode = false`.

Comment 7

[Stephan Leroux [:sleroux]]

Fixed nit with base class check for environment variable recording flag.

Comment 8

[Stephan Leroux [:sleroux]]

Merged

Master 19c230d4c7d08ec2ea77f8f153a550f686cf87af