1221707 - 'Similar jobs' shows outdated list of old previous jobs

Status: RESOLVED INVALID

(Tree Management :: Treeherder, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Using the 'Similar jobs' tab at the bottom shows a list of outdated jobs, e.g. from July or early October. That prevents from getting a quick overview how frequently a job turns orange or when it has started permafailing.

Example:
M(1) for Linux pgo from https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=835785b85db2

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This seems to be fixed after reloading my pinned Treeherder tabs.

Comment 2

[Ed Morley [:emorley]]

Bug 1221064 changed a few things, however it's not in production, so it can't be due to that.

Can you still reproduce your issue?

Comment 3

[Ed Morley [:emorley]]

Actually, Will did do a prod push 3 hours ago, so that bug is on production.

Either way, after a refresh did the issue go away? It may have just been that you had the stale JS assets, since the page hadn't been reloaded since the deploy.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I have still a tab which I didn't reload and requesting the 'Similar jobs' sends this GET request:
https://treeherder.mozilla.org/api/project/b2g-inbound/jobs/?build_platform_id=7&count=21&job_type_id=155&offset=0&option_collection_hash=32faaecac742100f7753f0c1d0aa0add01b4046b

Open b2g-inbound in a new tab shows these requests:

https://treeherder.mozilla.org/api/project/b2g-inbound/jobs/3260290/similar_jobs/?build_platform_id=7&count=21&offset=0&option_collection_hash=32faaecac742100f7753f0c1d0aa0add01b4046b

https://treeherder.mozilla.org/api/project/b2g-inbound/jobs/?count=2000&last_modified__gt=2015-11-04T21:54:06.000&result_set_id__in=10359,10358,10357,10356,10355,10354,10353,10352,10351,10350&return_type=list

Comment 5

[Ed Morley [:emorley]]

Yeah that's an expected result of bug 1221064 (tl;dr the perf of sorting was too high and unneeded for the main /jobs/ call, so sorting was removed there and a new endpoint added just for similar jobs).

You'll need to refresh your page to ensure your using the correct JS assets, since similar jobs should now use a different endpoint.

Comment 6

[Ed Morley [:emorley]]

Thank you for filing the bug though - was worth checking just in case :-)