1221758 - TEST-UNEXPECTED-FAIL | netwerk/test/unit/ test_cache2-30a-entry-pinning.js, test_cache2-30b-pinning-storage-clear.js, test_cache2-30c-pinning-deferred-doom.js, test_cache2-30d-pinning-WasEvicted-API.js

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Magnus Melin [:mkmelin]]

Didn't verify by changing the relevant prefs, but this should be since cache2 is not enable - bug 1021843.

6:40:10     INFO -  NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsICacheStorageService.pinningCacheStorage]
06:40:10     INFO -  getCacheStorage@C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/head_cache.js:53:1
06:40:10     INFO -  asyncOpenCacheEntry/CacheListener.prototype.run@C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/head_cache.js:90:21
06:40:10     INFO -  asyncOpenCacheEntry@C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/head_cache.js:95:4
06:40:10     INFO -  run_test@C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache2-30c-pinning-deferred-doom.js:60:1
06:40:10     INFO -  _execute_test@C:\slave\test\build\tests\xpcshell\head.js:514:7
06:40:10     INFO -  @-e:1:1
06:40:10     INFO -  PROCESS | 6384 | [6384] WARNING: TimelineConsumers could not be initialized.: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/docshell/base/timeline/TimelineConsumers.cpp, line 63
06:40:10     INFO -  PROCESS | 6384 | [6384] WARNING: OOPDeinit() without successful OOPInit(): file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/toolkit/crashreporter/nsExceptionHandler.cpp, line 2792
06:40:10     INFO -  PROCESS | 6384 | [6384] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/xpcom/base/nsTraceRefcnt.cpp, line 167
06:40:10     INFO -  PROCESS | 6384 | [6384] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/xpcom/base/nsTraceRefcnt.cpp, line 167
06:40:10     INFO -  PROCESS | 6384 | nsStringStats
06:40:10     INFO -  PROCESS | 6384 |  => mAllocCount:           4652
06:40:10     INFO -  PROCESS | 6384 |  => mReallocCount:          255
06:40:10     INFO -  PROCESS | 6384 |  => mFreeCount:            4652
06:40:10     INFO -  PROCESS | 6384 |  => mShareCount:           4695
06:40:10     INFO -  PROCESS | 6384 |  => mAdoptCount:            261
06:40:10     INFO -  PROCESS | 6384 |  => mAdoptFreeCount:        261
06:40:10     INFO -  PROCESS | 6384 |  => Process ID: 6384, Thread ID: 732
06:40:10     INFO -  <<<<<<<
06:40:10     INFO -  TEST-START | netwerk/test/unit/test_cache2-30b-pinning-storage-clear.js

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1221758_cache2_tb_testfailures.patch

Set the prefs to actually use cache2 before testing these.
cache2 isn't in use in Thunderbird yet so therefore we get errors here

Comment 2

[Magnus Melin [:mkmelin]]

Michal: ping on the review

Comment 3

[Michal Novotny [:michal]]

Comment on attachment 8684606 [details] [diff] [review]
bug1221758_cache2_tb_testfailures.patch

Review of attachment 8684606 [details] [diff] [review]:
-----------------------------------------------------------------

Instead of forcing the test to use cache2, the test simply shouldn't run with the old cache. I.e. there should be a check like in a lot of other cache2 specific tests:

if (!newCacheBackEndUsed()) {
  do_check_true(true, "This test checks only cache2 specific behavior.");
  return;
}

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1221758_cache2_tb_testfailures.patch

Updated, thx!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80a79987da8b

Comment 6

[Nigel Babu [:nigelb]]

Hello, this has caused xpcshell bustage.

Comment 7

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc9023a0d7619127c607db4e06986c8979c949ad
Backed out changeset 80a79987da8b (bug 1221758) for xpcshell bustage on CLOSED TREE

Comment 8

[Magnus Melin [:mkmelin]]

Ah sorry about that. 

TEST-UNEXPECTED-FAIL | netwerk/test/unit_ipc/test_cache_jar_wrap.js | xpcshell return code: 0
ReferenceError: newCacheBackEndUsed is not defined at /builds/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache_jar.js:92
Return code: 1

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: bug1221758_cache2_tb_testfailures.patch

Make the head_cache2.js functions accessible for netwerk/test/unit_ipc/test_cache_jar_wrap.js

Comment 10

[Magnus Melin [:mkmelin]]

Successful try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed4e7d2c1866

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c13cc541e37f

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c13cc541e37f