TEST-UNEXPECTED-FAIL | netwerk/test/unit/ test_cache2-30a-entry-pinning.js, test_cache2-30b-pinning-storage-clear.js, test_cache2-30c-pinning-deferred-doom.js, test_cache2-30d-pinning-WasEvicted-API.js

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mkmelin+mozilla, Assigned: mkmelin+mozilla)

Tracking

({intermittent-failure})

Trunk
mozilla45
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
Didn't verify by changing the relevant prefs, but this should be since cache2 is not enable - bug 1021843.

6:40:10     INFO -  NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsICacheStorageService.pinningCacheStorage]
06:40:10     INFO -  getCacheStorage@C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/head_cache.js:53:1
06:40:10     INFO -  asyncOpenCacheEntry/CacheListener.prototype.run@C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/head_cache.js:90:21
06:40:10     INFO -  asyncOpenCacheEntry@C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/head_cache.js:95:4
06:40:10     INFO -  run_test@C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache2-30c-pinning-deferred-doom.js:60:1
06:40:10     INFO -  _execute_test@C:\slave\test\build\tests\xpcshell\head.js:514:7
06:40:10     INFO -  @-e:1:1
06:40:10     INFO -  PROCESS | 6384 | [6384] WARNING: TimelineConsumers could not be initialized.: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/docshell/base/timeline/TimelineConsumers.cpp, line 63
06:40:10     INFO -  PROCESS | 6384 | [6384] WARNING: OOPDeinit() without successful OOPInit(): file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/toolkit/crashreporter/nsExceptionHandler.cpp, line 2792
06:40:10     INFO -  PROCESS | 6384 | [6384] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/xpcom/base/nsTraceRefcnt.cpp, line 167
06:40:10     INFO -  PROCESS | 6384 | [6384] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/xpcom/base/nsTraceRefcnt.cpp, line 167
06:40:10     INFO -  PROCESS | 6384 | nsStringStats
06:40:10     INFO -  PROCESS | 6384 |  => mAllocCount:           4652
06:40:10     INFO -  PROCESS | 6384 |  => mReallocCount:          255
06:40:10     INFO -  PROCESS | 6384 |  => mFreeCount:            4652
06:40:10     INFO -  PROCESS | 6384 |  => mShareCount:           4695
06:40:10     INFO -  PROCESS | 6384 |  => mAdoptCount:            261
06:40:10     INFO -  PROCESS | 6384 |  => mAdoptFreeCount:        261
06:40:10     INFO -  PROCESS | 6384 |  => Process ID: 6384, Thread ID: 732
06:40:10     INFO -  <<<<<<<
06:40:10     INFO -  TEST-START | netwerk/test/unit/test_cache2-30b-pinning-storage-clear.js
(Assignee)

Updated

3 years ago
Blocks: 1032254
Summary: TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_cache2-30b-pinning-storage-clear.js | xpcshell return code: 0 → TEST-UNEXPECTED-FAIL | netwerk/test/unit/ test_cache2-30a-entry-pinning.js, test_cache2-30b-pinning-storage-clear.js, test_cache2-30c-pinning-deferred-doom.js, test_cache2-30d-pinning-WasEvicted-API.js
(Assignee)

Comment 1

3 years ago
Created attachment 8684606 [details] [diff] [review]
bug1221758_cache2_tb_testfailures.patch

Set the prefs to actually use cache2 before testing these.
cache2 isn't in use in Thunderbird yet so therefore we get errors here
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8684606 - Flags: review?(michal.novotny)
(Assignee)

Comment 2

3 years ago
Michal: ping on the review
Comment on attachment 8684606 [details] [diff] [review]
bug1221758_cache2_tb_testfailures.patch

Review of attachment 8684606 [details] [diff] [review]:
-----------------------------------------------------------------

Instead of forcing the test to use cache2, the test simply shouldn't run with the old cache. I.e. there should be a check like in a lot of other cache2 specific tests:

if (!newCacheBackEndUsed()) {
  do_check_true(true, "This test checks only cache2 specific behavior.");
  return;
}
Attachment #8684606 - Flags: review?(michal.novotny) → review-
(Assignee)

Comment 4

3 years ago
Created attachment 8686727 [details] [diff] [review]
bug1221758_cache2_tb_testfailures.patch

Updated, thx!
Attachment #8684606 - Attachment is obsolete: true
Attachment #8686727 - Flags: review?(michal.novotny)
Attachment #8686727 - Flags: review?(michal.novotny) → review+
(Assignee)

Updated

3 years ago
Component: General → Networking: Cache
Product: Thunderbird → Core

Comment 6

3 years ago
Hello, this has caused xpcshell bustage.

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc9023a0d7619127c607db4e06986c8979c949ad
Backed out changeset 80a79987da8b (bug 1221758) for xpcshell bustage on CLOSED TREE
(Assignee)

Comment 8

3 years ago
Ah sorry about that. 

TEST-UNEXPECTED-FAIL | netwerk/test/unit_ipc/test_cache_jar_wrap.js | xpcshell return code: 0
ReferenceError: newCacheBackEndUsed is not defined at /builds/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache_jar.js:92
Return code: 1
(Assignee)

Comment 9

3 years ago
Created attachment 8687354 [details] [diff] [review]
bug1221758_cache2_tb_testfailures.patch

Make the head_cache2.js functions accessible for netwerk/test/unit_ipc/test_cache_jar_wrap.js
Attachment #8686727 - Attachment is obsolete: true
Attachment #8687354 - Flags: review?(michal.novotny)
Attachment #8687354 - Flags: review?(michal.novotny) → review+

Comment 12

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c13cc541e37f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.