1221770 - Can't differentiate Browser Console with the Console panel

Status: RESOLVED WONTFIX

(DevTools :: Console, defect)

Description

[Florent Fayolle]

In order to fix bug 433 from the Firebug.next issue list (https://github.com/firebug/firebug.next/issues/433 ), we would need some class (or ID, or so...) to differentiate the Browser Console from the regular Console panel in the DevTools.

We typically need it to hide the filter box (since there is already the Firebug search box) except when the user is in the Browser Console.

Florent

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I am not sure if the platform should do anything specific to fix that issue (I don't know about any other case that would require it).

Just for the record, the platform should rather support shared filter box for all panels (I think there is a bug report for this, but I can't find it).

In any case, Firebug.next can create an extra attribute that can be used to differentiate Web Console and Browser Console itself.

Consider the following code in ConsoleOverlay.onReady:

// Get panel frame content document
var panelDoc = this.getPanelDocument();

// Get reference to the original filter box
var filter = panelDoc.querySelector(".hud-filter-box.devtools-searchinput");

// Create an extra attribute (and use the attribute in appropriate CSS rule)
filter.setAttribute("panel", "true");

Honza

Comment 2

[Florent Fayolle]

We finally have used some tricks so we don't need a patch from the platform. Thus I close the issue.

Florent