1221827 - Send upgrade notice to users not running bundle2

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

Users are encouraged to run the latest stable Mercurial release. The lack of bundle2 on push means they are running 3.4 or older. We should nudge pushers on old versions to upgrade to a modern Mercurial version.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: hghooks: advertise mercurial upgrade to non-bundle2 clients (bug 1221827); r?dminor

hghooks: advertise mercurial upgrade to non-bundle2 clients (bug 1221827); r?dminor

Mercurial 3.5 and newer support a new wire protocol exchange format
called "bundle2." Not using bundle2 almost certainly means the client is
on an old version of Mercurial.

In an attempt to nudge people into using a modern version of Mercurial,
this commit adds a hook that will print a message to non-bundle2 users
during push encouraging them to upgrade. The message is purely advisory.

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8683406 [details]
MozReview Request: hghooks: advertise mercurial upgrade to non-bundle2 clients (bug 1221827); r?dminor

https://reviewboard.mozilla.org/r/24315/#review21877

::: hghooks/mozhghooks/advertise_upgrade.py:11
(Diff revision 1)
> +        ui.write('upgrade instructions are at the following URL\n')

I'd put a ':' at the end of this sentence

::: hghooks/mozhghooks/advertise_upgrade.py:13
(Diff revision 1)
> +        ui.write('you will see this message on every push until you upgrade\n')

This sounds a little punitive to me, but I'll leave it to your discretion if you want to keep this sentence or let them figure it out for themselves.

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/f2a7fa602ab4eef4b5ea34c0d13b58f50d01e159
hghooks: advertise mercurial upgrade to non-bundle2 clients (bug 1221827); r=dminor

Comment 4

[Gregory Szorc [:gps]]

Deploying now.

Comment 5

[Gregory Szorc [:gps]]

Backing out because MozillaBuild only ships 3.4 currently. Sad panda.

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/54be6cdc4b1efbd6f88068e3cd050d7d3fac5a7e
ansible/hg-ssh: disable upgrade advertisement (bug 1221827)

Comment 7

[Gregory Szorc [:gps]]

An updated MozillaBuild with Mercurial 3.6.1 has been released. All Mozillians should now have the ability to install Mercurial 3.5+ easily. So, I'm going to reland this shortly.

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/bea6998f398fc79839bc5961e4757a5a13e85a72
ansible/hg-ssh: enable upgrade advertisement (bug 1221827)

Comment 9

[Gregory Szorc [:gps]]

Advertisement deployed.

Comment 10

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/fa97317be812911f2e60644f05398ebeb0368a07
ansible/hg-ssh: disable upgrade advertisement (bug 1221827)

Comment 11

[Gregory Szorc [:gps]]

Backing out because git-cinnabar is not using bundle2 yet.

Comment 12

[Gregory Szorc [:gps]]

glandium: is cinnabar in a good enough state that we can re-deploy this?

Comment 13

[Mike Hommey [:glandium]]

There is no release of cinnabar with bundle2 support. It's still experimental and partial (no support for bundle2 pushes, yet). You should know, the status is in the issue you opened ;)

Comment 14

[Gregory Szorc [:gps]]

Modern versions of git-cinnabar appear to use bundle2 by default. So I'm going to rebase and land this.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/fe3153ff2508
ansible/hg-ssh: enable upgrade advertisement ; r=dminor

Comment 16

[Gregory Szorc [:gps]]

I also deployed this shortly after it landed. Nobody has said anything yet. That's usually a good sign.