Closed Bug 1221831 Opened 4 years ago Closed 4 years ago

use initial input buffer offset to control when convolver stages perform their FFT

Categories

(Core :: Web Audio, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(4 files)

The delay used in ReverbConvolverStage to stagger FFT calculation can be
replaced with an initial offset in the FFTConvolvers.  This removes
unnecessary buffering, providing 3% improvement on the convolution reverb
benchmark, and also allows for better staggering through offsets even when the
stage is running at minimum latency, which is useful for bug 1221830.
Keywords: perf
bug 1221831 remove unused Reverb::reset() r?padenot
Attachment #8683436 - Flags: review?(padenot)
bug 1221831 remove unused Reverb::latencyFrames() r?padenot
Attachment #8683437 - Flags: review?(padenot)
bug 1221831 use initial input buffer offset to control when convolver stages perform their FFT r?padenot
Attachment #8683438 - Flags: review?(padenot)
bug 1221831 remove now-unnecessary m_preDelayBuffer r?padenot
Attachment #8683439 - Flags: review?(padenot)
Rank: 12
Priority: -- → P1
Attachment #8683436 - Flags: review?(padenot) → review+
Comment on attachment 8683436 [details]
MozReview Request: bug 1221831 remove unused Reverb::reset() r?padenot

https://reviewboard.mozilla.org/r/24331/#review21829
Comment on attachment 8683437 [details]
MozReview Request: bug 1221831 remove unused Reverb::latencyFrames() r?padenot

https://reviewboard.mozilla.org/r/24333/#review21831
Attachment #8683437 - Flags: review?(padenot) → review+
Comment on attachment 8683438 [details]
MozReview Request: bug 1221831 use initial input buffer offset to control when convolver stages perform their FFT r?padenot

https://reviewboard.mozilla.org/r/24335/#review21837
Attachment #8683438 - Flags: review?(padenot) → review+
Comment on attachment 8683439 [details]
MozReview Request: bug 1221831 remove now-unnecessary m_preDelayBuffer r?padenot

https://reviewboard.mozilla.org/r/24337/#review21839
Attachment #8683439 - Flags: review?(padenot) → review+
You need to log in before you can comment on or make changes to this bug.