Closed
Bug 1221831
Opened 9 years ago
Closed 9 years ago
use initial input buffer offset to control when convolver stages perform their FFT
Categories
(Core :: Web Audio, defect, P1)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(4 files)
The delay used in ReverbConvolverStage to stagger FFT calculation can be replaced with an initial offset in the FFTConvolvers. This removes unnecessary buffering, providing 3% improvement on the convolution reverb benchmark, and also allows for better staggering through offsets even when the stage is running at minimum latency, which is useful for bug 1221830.
|
Assignee | |
Comment 1•9 years ago
|
||
bug 1221831 remove unused Reverb::reset() r?padenot
Attachment #8683436 -
Flags: review?(padenot)
|
|
Assignee | |
Comment 2•9 years ago
|
||
bug 1221831 remove unused Reverb::latencyFrames() r?padenot
Attachment #8683437 -
Flags: review?(padenot)
|
|
Assignee | |
Comment 3•9 years ago
|
||
bug 1221831 use initial input buffer offset to control when convolver stages perform their FFT r?padenot
Attachment #8683438 -
Flags: review?(padenot)
|
|
Assignee | |
Comment 4•9 years ago
|
||
bug 1221831 remove now-unnecessary m_preDelayBuffer r?padenot
Attachment #8683439 -
Flags: review?(padenot)
|
||
Updated•9 years ago
|
Rank: 12
Priority: -- → P1
|
||
Updated•9 years ago
|
Attachment #8683436 -
Flags: review?(padenot) → review+
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8683436 [details] MozReview Request: bug 1221831 remove unused Reverb::reset() r?padenot https://reviewboard.mozilla.org/r/24331/#review21829
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8683437 [details] MozReview Request: bug 1221831 remove unused Reverb::latencyFrames() r?padenot https://reviewboard.mozilla.org/r/24333/#review21831
Attachment #8683437 -
Flags: review?(padenot) → review+
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8683438 [details] MozReview Request: bug 1221831 use initial input buffer offset to control when convolver stages perform their FFT r?padenot https://reviewboard.mozilla.org/r/24335/#review21837
Attachment #8683438 -
Flags: review?(padenot) → review+
|
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8683439 [details] MozReview Request: bug 1221831 remove now-unnecessary m_preDelayBuffer r?padenot https://reviewboard.mozilla.org/r/24337/#review21839
Attachment #8683439 -
Flags: review?(padenot) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed6c2d2908ac https://hg.mozilla.org/integration/mozilla-inbound/rev/a2dfe0020083 https://hg.mozilla.org/integration/mozilla-inbound/rev/71f52b56cf72 https://hg.mozilla.org/integration/mozilla-inbound/rev/25f3b37be048
|
||
Comment 10•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ed6c2d2908ac https://hg.mozilla.org/mozilla-central/rev/a2dfe0020083 https://hg.mozilla.org/mozilla-central/rev/71f52b56cf72 https://hg.mozilla.org/mozilla-central/rev/25f3b37be048
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•