1221836 - return output pointer from FFTConvolver::process() to save a buffer copy

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P1)

Description

[Karl Tomlinson (:karlt)]

FFTConvolver copies its output to a provided buffer, but it already has the
output in its own buffer and so can instead provide a pointer to the buffer.

This requires dropping support for FFT half-sizes less than WEBAUDIO_BlOCK_SIZE, which we don't really use after changes in bug, but saves 4-5% CPU usage.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1221836 return output pointer from FFTConvolver::process() to save a buffer copy r?padenot

bug 1221836 return output pointer from FFTConvolver::process() to save a buffer copy r?padenot

Comment 2

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bfe2601f3af

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8683449 [details]
MozReview Request: bug 1221836 return output pointer from FFTConvolver::process() to save a buffer copy r?padenot

https://reviewboard.mozilla.org/r/24361/#review21875

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21612d903003

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21612d903003