1221890 - Rename DOMMediaStream to its rightful name MediaStream

Status: NEW

(Core :: Audio/Video: MediaStreamGraph, defect, P4)

Description

[Andreas Pehrson [:pehrsons]]

There is some confusion about the naming of streams, for instance we have DOMMediaStream which according to spec is called MediaStream, and we have MediaStream and friends as defined by MediaStreamGraph.

The idea is to rename the MSG-MediaStream classes to something suitable (bikeshedding welcome) and give DOMMediaStream its rightful name MediaStream.

I have CCed the people I think could have some input on the topic.

We started thinking about this a bit already in bug 1208371 comments 47, 54, 56 and 64. Due to the immense bug spam that ensued there I'm moving this discussion here instead. In short the suggested names so far are:

MSGMediaStream
MsgStream
MediaStreamNode
GraphMediaStream
RTMediaStream
RealtimeMediaStream
AsyncMediaStream

..and similarly for
ProcessedMediaStream
TrackUnionStream
SourceMediaStream

and perhaps some more.


Thoughts?

Comment 1

[Andreas Pehrson [:pehrsons]]

I voted MSGMediaStream originally but don't like that it's abbreviated.

As roc points out in bug 1208371 comment 64, GraphMediaStream could be confused with MediaStreamGraph, otherwise I would have preferred that.

InternalMediaStream?

Comment 2

[Karl Tomlinson (:karlt)]

MSGStream would be fine with me.
Maybe even MSGNode, but we probably have many comments calling them streams.
I don't find MediaStreamNode helpful to indicate graph thread.

Comment 3

[Andreas Pehrson [:pehrsons]]

I discussed this with padenot and jesup in London and we agreed on the following changes.

DOMMediaStream -> MediaStream
DOMLocalMediaStream -> LocalMediaStream
DOMAudioNodeMediaStream -> AudioNodeMediaStream
MediaStream -> StreamBase
SourceMediaStream -> SourceStream
ProcessedMediaStream -> ProcessedStream
CameraPreviewMediaStream -> CameraPreviewStream

Comment 4

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.