1221964 - Implement "Save as File" in context menu

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[YF (Yang)]

For example, save an image to disk, instead of opening it in a new tab, and then Save as.


Opinions:
Read it from the cache first. Use the original heades.
It may fail due to the unique request. Should be warned that if the POST form.

Alternatively, ask to request if misses from the cache.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This sounds similar to the "Save Response Body" feature recently requested on Twitter:

https://twitter.com/13xforever/status/930020325768691713

Comment 2

[Florens Verschelde :fvsch]

See also: bug 966209 which implemented a "Save Image As" context menu entry 2 years ago.

Not sure if that implementation reads from the cache or re-requests the image.

It feels like for "static" resources such as CSS, JS, Fonts and Media, it could be safe to just do a new request.
For video, it might actually be better to do a new request because of the partial content stuff?

Comment 3

[Aaron]

Attachment: Bug 1221964 - Replace netmonitor 'Save Image As' with 'Save Response As'

The implementation of the 'Save Image As' context menu already supported
working with arbitrary response content, but it was only displayed for
responses with an 'image/' MIME type.

This patch removes the MIME type restriction, renames the context menu
option to 'Save Response As', and adds a test (the old 'Save Image As'
option seems to have lacked any tests).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09d9cc9342a6
Replace netmonitor 'Save Image As' with 'Save Response As' r=devtools-reviewers,nchevobbe

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/09d9cc9342a6

Comment 6

[Pascal Chevrel:pascalc]

Aaron, is that worth a mention in our release notes? Thanks

Comment 7

[Aaron]

Yes - I think many people are going to find this useful. Is there anything else that I need to do to get this added to the release notes?

Comment 8

[Pascal Chevrel:pascalc]

You can follow the instructions in https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination to nominate this bug for release notes addition directly in Bugzilla.

Comment 9

[Aaron]

Release Note Request (optional, but appreciated)
[Why is this notable]: Allows developers to save a network response to disk, avoiding the need to use an external tool to resend the request with the proper headers and request body.
[Affects Firefox for Android]: No
[Suggested wording]: The Network Monitor now supports saving a response body to disk through the 'Save Response As' context menu item. This replaces the 'Save Image' context menu item, which only supported saving images.
[Links (documentation, blog post, etc)]:

Comment 10

[Pascal Chevrel:pascalc]

Note added to our 123 nightly release notes, thanks!