1222025 - persist selected job in URL so it re-selects on page reload

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Cameron Dawson [:camd]]

this should be really easy to do and would make it easier to share a specific job without having to filter down to that specific job.

Comment 1

[Cameron Dawson [:camd]]

Attachment: PR

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8685609 [details] [review]
PR

Only quickly glanced at this, but as long as you've tested locally, lgtm :-)

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/05692dcea73546b1d7aa3f52b4a711e277d7c5fc
Bug 1222025 - persist selected job in URL so it re-selects on page reload

If the url is used and the job is not found in the loaded result sets, then throw up an
error notification with a link to load the right resultset and selectedJob.  This could
happen if a job was selected, but no revision range provided and that job's resultset
was no longer in the "last 10" that get loaded by default.

Comment 4

[Cameron Dawson [:camd]]

Ed: thanks for the review.  yeah, I've tested it quite a bit.  I think it's solid.