Homescreen dialogs should be combined

RESOLVED WONTFIX

Status

Firefox OS
Gaia::UI Tests
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Martijn Wargers (dead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Assignee)

Description

2 years ago
I see a lot of similar code in:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/

I have 2 thing
- Perhaps we could combine these dialog in 1 general dialog from which we can work on?
- I think it makes more sense if these were part of the system app region, because these are system dialogs

Johan, what do you think?
Flags: needinfo?(jlorenzo)
I totally agree! IIRC, the bookmark menu[1] should disappear with bug 1217404. All the rest can be in 1 class with methods like: confirm() and cancel().

[1] http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/bookmark_menu.py
Flags: needinfo?(jlorenzo)
See Also: → bug 1217404
(Assignee)

Comment 2

2 years ago
Gaia UI tests are becoming obsolete, so marking WONTFIX.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.