1222135 - [User Story] App Grouping

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[Ben Francis [:benfrancis]]

Chris, do you know who from UX will be providing a spec for this?

Comment 2

[Chris Lord [:cwiiis]]

(In reply to Ben Francis [:benfrancis] from comment #1)
> Chris, do you know who from UX will be providing a spec for this?

I spoke to Rob about this on Friday, I have a not-a-spec for this and we discussed how this was going to work, so I have a basic idea of where we're going here and enough to start work on it once I'm done with rearranging pinned pages. I think full specs will come at some point after Mozlando.

Comment 3

[Ben Francis [:benfrancis]]

Prototyping work happening in bug 1227259

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1222135-homescreen-folders > mozilla-b2g:master

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8704189 [details] [review]
[gaia] Cwiiis:bug1222135-homescreen-folders > mozilla-b2g:master

I haven't done a tidy-pass on this code yet, and I'm still in the midst of writing tests, but I don't envision the code changing significantly now. The basic functionality is there and appears to be working and performing reasonably (there's always room for improvement of course).

I think it's about time to get some feedback - let me know what you think.

Comment 6

[Alison Shiue]

Hi Rob, may I know when will we have the UX spec for this feature?

Comment 7

[Guillaume Marty [:gmarty]]

Comment on attachment 8704189 [details] [review]
[gaia] Cwiiis:bug1222135-homescreen-folders > mozilla-b2g:master

I left a couple of comments and still have a few nits but I really like how you managed to keep modularity and code readability even with the increased complexity.

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 8704189 [details] [review]
[gaia] Cwiiis:bug1222135-homescreen-folders > mozilla-b2g:master

I've addressed the nits you pointed out in your feedback. There's some polish, but the major difference now is tests - there are a few marionette tests covering all the basic functionality and fairly extensive unit testing of all newly introduced functions and features.

Apologies for how huge this is.

One relatively large thing missing from this patch is edit mode in groups - I'd like to address this in follow-up.

Comment 9

[Alison Shiue]

Will this feature be landed in 2.6?

Comment 10

[Chris Lord [:cwiiis]]

(In reply to Alison Shiue from comment #9)
> Will this feature be landed in 2.6?

Pending review, yes. gmarty?

Comment 11

[Guillaume Marty [:gmarty]]

Comment on attachment 8704189 [details] [review]
[gaia] Cwiiis:bug1222135-homescreen-folders > mozilla-b2g:master

I left a couple of nits, but overall this is a great job!

Comment 12

[Chris Lord [:cwiiis]]

There are some failing tests, but they seem to be in entirely unrelated things that don't go near anything that's changed, so I'm chancing it - we can always back out.

Merged: https://github.com/mozilla-b2g/gaia/commit/3b3621bcc3e277465588ddc24491e18fefaa9108

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:revert-33751-bug1222135-homescreen-folders > mozilla-b2g:master

Comment 14

[Scott Wu [:scottwu]]

Reverted: https://github.com/mozilla-b2g/gaia/commit/359c848072b132f73507357b195f91df54ee4691

This patch caused the home screen app icons to disappear. I did reset-gaia on my z3c device while fixing another bug, and found out the home screen became empty. The issue goes away if I drop this commit. Please take a look. Thanks!

Comment 15

[Chris Lord [:cwiiis]]

(In reply to Scott Wu [:scottwu] from comment #14)
> Reverted:
> https://github.com/mozilla-b2g/gaia/commit/
> 359c848072b132f73507357b195f91df54ee4691
> 
> This patch caused the home screen app icons to disappear. I did reset-gaia
> on my z3c device while fixing another bug, and found out the home screen
> became empty. The issue goes away if I drop this commit. Please take a look.
> Thanks!

I just checked, and this works fine for me and the marionette tests pass, which heavily involves icons on the home-screen. Are you using an old Gecko? The last commit introduced the spread operator (which was one of the nits) - could you attach your logcat?

Comment 16

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:revert-34068-revert-33751-bug1222135-homescreen-folders > mozilla-b2g:master

Comment 17

[Scott Wu [:scottwu]]

You are right! I was using an older gecko and it's working fine now that I've updated to the latest.

Sorry for the oversight on my part! I've reverted my revert.