1222237 - Investigate DrawTarget errors on 2.3 for zoomed view

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Moving NI.

via bug 1208370 comment 35:
Michael, I made the changes in the pref using the values proposed by Anthony.
I cannot test those settings using my device (Android 2.3.3), the nightly code is currently totally broken: firefox vertical menu is unreadable, wrong size for the search pictures in about:config, and the zoomed view is never displayed.

The issue regarding the zoomed view could come from a change on DrawTarget in Gecko code. I can see the following messages in the log just after the call to create the bitmap used by the zoomed view:

11-01 07:47:03.525: I/Gecko(7084): [GFX1]: Attempt to create DrawTarget for invalid surface. Size(240,240) Cairo Status: 24
11-01 07:47:03.525: I/Gecko(7084): [GFX1-]: Failed to create DrawTarget, Type: 4 Size: Size(240,240), Data: 0x, Stride: 32
---

(wfm on GS4 then...) via bug 1208370 comment 39:
It's probably a 2.3 problem. The issues are still visible with the last nightly version of the code. You can see in the attached picture the different visible issues and also the log error when the zoomed view is triggered.

Are there some changes on the Gecko side regarding the display of bitmap using DrawTarget?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #0)
> Are there some changes on the Gecko side regarding the display of bitmap
> using DrawTarget?

I don't know anything about DrawTarget – Snorp, do you know or can you reroute?

Comment 2

[Dominique Vincent [:domivinc]]

Regarding the zoomedview issue (visible only on Android 2.3), it seems to come from the following push:

https://hg.mozilla.org/mozilla-central/rev/2708f83e4c15

This code change is described here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1209812#c2

Are we sure that the previous comment is true for the Android 2.3 platform? The method used to build the zoomedview bitmap is AndroidBridge::CaptureZoomedView. The code is here:

https://dxr.mozilla.org/mozilla-central/source/widget/android/AndroidBridge.cpp#1822

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to Dominique Vincent [:domivinc] from comment #2)
> Regarding the zoomedview issue (visible only on Android 2.3), it seems to
> come from the following push:
> 
> https://hg.mozilla.org/mozilla-central/rev/2708f83e4c15
> 
> This code change is described here:
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=1209812#c2
> 
> Are we sure that the previous comment is true for the Android 2.3 platform?

Pretty sure, but I did introduce a problem with that patch, which I fixed just yesterday in bug 1222171. Please update and try again, hopefully it will now be fixed.

Comment 4

[Dominique Vincent [:domivinc]]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> 
> Pretty sure, but I did introduce a problem with that patch, which I fixed
> just yesterday in bug 1222171. Please update and try again, hopefully it
> will now be fixed.

Yes, the issue in the zoomed view is now fixed, thanks!

Comment 5

[Nicholas Nethercote [inactive]]

Excellent. Thank you for verifying.