Closed Bug 1222323 Opened 8 years ago Closed 8 years ago

Avoid passing extra defines to the compiler from config.mk

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

Avoid passing extra defines to the compiler from config.mk
7.24 KB, patch
gps
: review+
Details | Diff | Splinter Review 
      No description provided.
C/C++ code should not be relying on XPI_NAME or AB_CD being defined, so
moving them out works.
Attachment #8684031 - Flags: review?(gps)
Attachment #8684031 - Flags: review?(gps) → review+
And backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3badc5e883a6 because packager no longer had any idea what AB_CD meant.
With a few more changes to not blatantly fail to build.
Attachment #8684031 - Attachment is obsolete: true
Attachment #8686998 - Flags: review?(gps)
Blocks: fast-compiledb
Comment on attachment 8686998 [details] [diff] [review]
Avoid passing extra defines to the compiler from config.mk

Review of attachment 8686998 [details] [diff] [review]:
-----------------------------------------------------------------

Why am I still scared every time we touch packaging code?
Attachment #8686998 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/8f3b9c2b450c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.