Tapping "Mark as Read" button from Reading List panel won't disappear on Ipad Air

RESOLVED FIXED

Status

()

Firefox for iOS
Reader View
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: TeoVermesan, Unassigned, Mentored)

Tracking

unspecified
ARM
iOS

Firefox Tracking Flags

(fxios-)

Details

(Whiteboard: [good first bug][lang=swift][iOS9])

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
fluffyemily
: review+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
Tested using:
Device: Ipad Air (IOS 9.0.2)
Build: Version 1.2 (1201)

Steps to reproduce:
1. Go to news.google.com and open two articles in new tabs
2. Enter reader view by tapping the Reader Mode icon on URL Bar 
3. Add articles to Reading List
4. Go to the Reading List panel from about:home
5. Tap the "Mark as Read" blue button from the left side.

Expected results:
- "Mark as Read" button will disappear.

Actual results:
-if you tap the "Mark as Read" button on the first article, it will become "Mark as unread". Now tapping the "Mark as unread" button, will disappear and text becomes unread.
-if you tap the "Mark as Read" button on the second article, it will disappear.

Updated

2 years ago
tracking-fxios: --- → ?
Mentor: sleroux@mozilla.com, bnicholson@mozilla.com
Whiteboard: [good first bug][lang=swift]
tracking-fxios: ? → -

Comment 1

2 years ago
I've done some tests and the problem occurs on iPad 2 too. The actual problem is that the "Mark as Read" button should not be displayed when arriving on the view, as on iPhone.

This is an issue of the SWTableViewCell library used to handle the swipe actions and it occurs on iOS 9 only. It has been reported[1] and a hack is proposed to fix it. I tested it and it actually works. However, this is a hack... and is a workaround for the real issue I think.

[1]: https://github.com/CEWendel/SWTableViewCell/issues/353
Thanks for the digging!
Whiteboard: [good first bug][lang=swift] → [good first bug][lang=swift][iOS9]

Comment 3

2 years ago
You're welcome :)

Comment 4

2 years ago
Hi, I would like to attempt this bug as a good first bug. University of Toronto, CSC302H1S-2015	
assignment. Patch by Feb 26,2016.

Comment 5

2 years ago
I will attempt to fix this as my first bug - CSC302 University of Toronto

Comment 6

2 years ago
disregard last comment

Comment 7

2 years ago
Created attachment 8734613 [details] [review]
Pull request
Attachment #8734613 - Flags: review?(etoop)
Comment on attachment 8734613 [details] [review]
Pull request

Thanks loads for this. Sorry for taking so long to review it - it got missed in my review queue.
Attachment #8734613 - Flags: review?(etoop) → review+
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.