1222479 - Use ObjDirPaths for GENERATED_INCLUDES and merge with LOCAL_INCLUDES (TB and IB)

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Philip Chee]

See Bug 1221453 - Use Path classes for LocalInclude/GeneratedIncludes

> ==============================
> ERROR PROCESSING MOZBUILD FILE
> ==============================
> The error occurred while processing the following file:
>     c:/t1/hg/comm-central/suite/app/moz.build
> The error was triggered on line 14 of this file:
>     GENERATED_INCLUDES += ['/build']
> The underlying problem is an attempt to read a reserved UPPERCASE variable that does not exist.
> The variable read causing the error is:
>     GENERATED_INCLUDES
> Maybe you meant GENERATED_FILES or GENERATED_WEBIDL_FILES?
> Please use
>     LOCAL_INCLUDES += [ '!foo' ]
> instead of
>     GENERATED_INCLUDES += [ 'foo' ]

Comment 1

[Philip Chee]

Attachment: Patch for Thunderbird and Instantbird

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8684264 [details] [diff] [review]
Patch for Thunderbird and Instantbird

Review of attachment 8684264 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. rs=me for the simple port.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/c97151456e748cd47ecfa1ad20ca10bc527d2058
Bug 1222479 - Use ObjDirPaths for GENERATED_INCLUDES and merge with LOCAL_INCLUDES (TB and IB). r=clokep a=bustage fix CLOSED TREE