Closed
Bug 1222495
Opened 9 years ago
Closed 9 years ago
Get dom/workers/test/test_suspend.html working with e10s
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.60 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
This test fails because it sets preferences directly using the preference service rather than using SpecialPowers.pushPrefEnv(). This seems to flip the pref on and off a number of times, and has a bunch of interconnected callbacks. The control flow will probably need to be rewritten to use Promises or something but I haven't been able to get my head around it yet.
Updated•9 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Assignee | ||
Comment 1•9 years ago
|
||
I misunderstood how this works. pushPrefEnv still uses a matching popPrefEnv. So it shouldn't be too bad.
Assignee: nobody → continuation
Assignee | ||
Comment 2•9 years ago
|
||
This is the last plain Mochitest in dom/workers/test/ that is not enabled with e10s. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0258ece2c04d
Attachment #8686089 -
Flags: review?(khuey)
Comment 3•9 years ago
|
||
I wonder if this tests passes on b2g with these changes. Is it worth pushing to try with it enabled there?
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #3) > I wonder if this tests passes on b2g with these changes. Is it worth pushing > to try with it enabled there? I don't know of any reason it wouldn't. I'll do a try push.
Attachment #8686089 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 5•9 years ago
|
||
B2G try run looked fine so I'm enabling it there, too: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6148567df12c
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0df5a6f549d4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•