1222495 - Get dom/workers/test/test_suspend.html working with e10s

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Andrew McCreight [:mccr8]]

This test fails because it sets preferences directly using the preference service rather than using SpecialPowers.pushPrefEnv(). This seems to flip the pref on and off a number of times, and has a bunch of interconnected callbacks. The control flow will probably need to be rewritten to use Promises or something but I haven't been able to get my head around it yet.

Comment 1

[Andrew McCreight [:mccr8]]

I misunderstood how this works. pushPrefEnv still uses a matching popPrefEnv. So it shouldn't be too bad.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Get dom/workers/test/test_suspend.html working with e10s.

This is the last plain Mochitest in dom/workers/test/ that is not enabled with e10s.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0258ece2c04d

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

I wonder if this tests passes on b2g with these changes. Is it worth pushing to try with it enabled there?

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #3)
> I wonder if this tests passes on b2g with these changes. Is it worth pushing
> to try with it enabled there?

I don't know of any reason it wouldn't. I'll do a try push.

Comment 5

[Andrew McCreight [:mccr8]]

B2G try run looked fine so I'm enabling it there, too:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=6148567df12c

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0df5a6f549d4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0df5a6f549d4