Closed Bug 1222495 Opened 6 years ago Closed 6 years ago

Get dom/workers/test/test_suspend.html working with e10s

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
e10s + ---
firefox45 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This test fails because it sets preferences directly using the preference service rather than using SpecialPowers.pushPrefEnv(). This seems to flip the pref on and off a number of times, and has a bunch of interconnected callbacks. The control flow will probably need to be rewritten to use Promises or something but I haven't been able to get my head around it yet.
Blocks: e10s-tests
tracking-e10s: --- → +
I misunderstood how this works. pushPrefEnv still uses a matching popPrefEnv. So it shouldn't be too bad.
Assignee: nobody → continuation
This is the last plain Mochitest in dom/workers/test/ that is not enabled with e10s.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0258ece2c04d
Attachment #8686089 - Flags: review?(khuey)
I wonder if this tests passes on b2g with these changes. Is it worth pushing to try with it enabled there?
(In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #3)
> I wonder if this tests passes on b2g with these changes. Is it worth pushing
> to try with it enabled there?

I don't know of any reason it wouldn't. I'll do a try push.
B2G try run looked fine so I'm enabling it there, too:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=6148567df12c
https://hg.mozilla.org/mozilla-central/rev/0df5a6f549d4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.