1222542 - Run eslint against all of the ui/ directory not just ui/js/

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Since currently the JS files under ui/partials/ and ui/plugins/ are not checked.

Comment 1

[Ed Morley [:emorley]]

Attachment: Run eslint against all of the ui/ directory

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8684332 [details] [review]
Run eslint against all of the ui/ directory

I'm a bit concerned that this will run the eslinting rules against files in vendor/, which I don't think is what we want. Is there something I'm missing?

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8684332 [details] [review]
Run eslint against all of the ui/ directory

Missed the entry excluding vendors in .eslintrc. Looks good otherwise!

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2ff44d7073354fcdca2a459e34c9356e5b05c32a
Bug 1222542 - Fix eslint indentation errors in ui/plugins/*

So we can start running eslint against this directory shortly.

https://github.com/mozilla/treeherder/commit/766838a5c62444776391548d354eb7885a7c4c9c
Bug 1222542 - Run eslint against all of the ui/ directory

Since previously the JS files under ui/partials/ and ui/plugins/ were
omitted. We now need to also explicitly exclude the vendor directory,
which we can do using `.eslintignore`.

This also means that if people prefer to run eslint directly, they
can use `eslint ui/` rather than having to type out the multiple
directories used previously.