1222570 - NS_APP_USER_SEARCH_DIR should not be added to NS_APP_SEARCH_DIR_LIST

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect, P4)

Description

[:Gavin Sharp [email: [e-mail]]]

Currently, the logic that determines which engines are loaded in which order is spread across two different places:

- the actual nsSearchService code (e.g. http://hg.mozilla.org/mozilla-central/annotate/6077f51254c6/toolkit/components/search/nsSearchService.js#l2873), which essentially just looks at both NS_APP_DISTRIBUTION_SEARCH_DIR_LIST and NS_APP_SEARCH_DIR_LIST locations (but with NS_APP_USER_SEARCH_DIR filtered out of NS_APP_SEARCH_DIR_LIST)

- the various apps' directory service definitions for NS_APP_DISTRIBUTION_SEARCH_DIR_LIST and NS_APP_SEARCH_DIR_LIST (e.g. https://hg.mozilla.org/mozilla-central/annotate/42627d5369b3/browser/components/dirprovider/DirectoryProvider.cpp#l226 or https://mxr.mozilla.org/mozilla-central/source/mobile/android/components/DirectoryProvider.js#160)

This seems like it could be simplified and/or consolidated, post bug 1109354. At the very least, I don't think it makes sense for the directory service implementations to include NS_APP_USER_SEARCH_DIR in their results, only to have the search service filter it out.

(I also think that right now Fennec's definition of search dirs is completely superfluous because they only use JAR loading, so their directory service provider could probably be cleaned up, but I'll file a separate bug for that.)

Comment 1

[Florian Quèze [:florian]]

After bug 1405670, this is no longer relevant, closing.