1222722 - _missing_apache_modules in Bugzilla::Install::Requirements.pm does not quote path to httpd resulting in not checking for missing modules

Status: UNCONFIRMED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Wayne]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.71 Safari/537.36

Steps to reproduce:

perl checksetup.pl -t


Actual results:

WARNING: We could not check the configuration of Apache. This sometimes
happens when you are not running checksetup.pl as Administrator. To see the
problem we ran into, run: C:\Program Files (x86)\Apache Software Foundation\Apache2.2\bin\httpd.EXE -t -D DUMP_MODULES



Expected results:

checksetup.pl should have run sucessfully

Comment 1

[Wayne]

The error is on line 521 of Requirements.pm or in _get_apachectl() (lines 581 & 586) depending on where you want to fix it. bin_loc() in Util.pm is also a candidate.

bin_loc is returning a path that has spaces in it. e.g "C:\Program Files (x86)\Apache Software Foundation\Apache2.2\bin\httpd.EXE" but _get_apachectl() is not quoting the command before executing it.

my $apachectl = _get_apachectl();
return [] if !$apachectl;
my $command = "$apachectl -t -D DUMP_MODULES";

On Windows it should be 

my $command = "\"$apachectl\" -t -D DUMP_MODULES";