Closed Bug 1222879 Opened 9 years ago Closed 7 years ago

[Not e10s] window.open without features not diverting to a tab with dom.disable_window_open_feature.minimizable = true

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Version:
42 Branch
Type:
defect

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
e10s + ---

People

(Reporter: jscher, Unassigned)

References

(
URL
)

Details

(Keywords: regression, testcase)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 Build ID: 20151029151421 Steps to reproduce: Clinked a link calling window.open() without features, for example, the second link in this test case: http://jeffersonscher.com/res/popit.html Firefox has its default settings for browser.link.open_newwindow and browser.link.open_newwindow.restriction; running NoScript with scripts allowed for the test case site. Actual results: Firefox 42 launches a new window. Expected results: Firefox 42 should have diverted the target page to a new tab.
Works for me. The second link opened a new tab on Firefox 42. (I'm not installing NoScript.)
You don't have to install NoScript, I just wanted to mention that I was not blocking scripts on the site. Upon further exploration, this problem appears to be caused by setting the dom.disable_window_open_feature.minimizable preference to true. Toggling it back to the default value of false allows the test case to work normally. I don't see anything unusual about how "minimizable" is handled in nsWindowWatcher.cpp compared with other preferences on this branch that don't cause any issues, but then I don't understand C++ very well.
(In reply to Jefferson from comment #2) > Upon further exploration, this problem appears to be caused by setting the > dom.disable_window_open_feature.minimizable preference to true. Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0 20151107004047 Only reproducible with e10s disabled.
URL: http://jeffersonscher.com/res/popit.html
Status: UNCONFIRMED → NEW
Component: Untriaged → DOM: Core & HTML
Ever confirmed: true
Keywords: testcase
Product: Firefox → Core
Summary: window.open without features not diverting to a tab → [Not e10s] window.open without features not diverting to a tab with dom.disable_window_open_feature.minimizable = true
Bill, is this a regression from some of the e10s window.open work?
Flags: needinfo?(wmccloskey)
Flags: needinfo?(mconley)
Mike is probably the best person to answer this.
Flags: needinfo?(wmccloskey)
Push log: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9c919ce631ea&tochange=5df788c56ae7 Suspect: bug 1114299
Blocks: 1114299
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regressionwindow-wanted → regression
tracking-e10s: --- → +
Priority: -- → P3
(I'm clearly never going to get to this needinfo, I'm afraid. :( )
Flags: needinfo?(mconley)
I think this bug is obsolete and can be closed now because it was "not e10s" which is no longer relevant.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.