Create log system for the AudioChannel

RESOLVED FIXED in Firefox 45

Status

Firefox OS
AudioChannel
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

unspecified
2.6 S1 - 11/20

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Create log system for AudioChannel, so that we can debug problem more easily.
Created attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

Bug 1222902 - Create log system for the AudioChannel
Attachment #8684796 - Flags: review?(amarchesini)
Hi, Baku,
As the AudioChannel doesn't have the log system, other people can't provide me useful logs to figure out the problem.
Therefore, I will want to add some log for it.
Comment on attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

https://reviewboard.mozilla.org/r/24641/#review22191

::: dom/audiochannel/AudioChannelAgent.cpp:137
(Diff revision 1)
> +          this, mAudioChannelType, mWindow.get(), hasCallback));

put this inline: (!!mCallback || !!mWeakCallback)

::: dom/audiochannel/AudioChannelAgent.cpp:169
(Diff revision 1)
> +          this, *aMuted));

print also the volume.

::: dom/audiochannel/AudioChannelAgent.cpp:217
(Diff revision 1)
> +         ("AudioChannelAgent, WindowVolumeChanged, this = %p, mute = %d\n",

volume here too.

::: dom/audiochannel/AudioChannelService.cpp:791
(Diff revision 1)
> +  MOZ_LOG(GetAudioChannelLog(), LogLevel::Debug,

Add the same for SetAudioChannelVolume.
Attachment #8684796 - Flags: review?(amarchesini) → review+
Comment on attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24641/diff/1-2/
Attachment #8684796 - Attachment description: MozReview Request: Bug 1222902 - Create log system for the AudioChannel → MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.
Attachment #8684796 - Flags: review+
Try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0dc5e35a86fd
Keywords: checkin-needed
Comment on attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24641/diff/2-3/
Rebase the patch.

Comment 8

2 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/9b2c15970aa0
Keywords: checkin-needed
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=3314715&repo=b2g-inbound
Flags: needinfo?(alwu)
New try-server result for win8 build.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f4c2fd810f4
Flags: needinfo?(alwu)

Comment 11

2 years ago
Backout:
https://hg.mozilla.org/integration/b2g-inbound/rev/eeb80d0df72f
Comment on attachment 8684796 [details]
MozReview Request: Bug 1222902 - Create log system for the AudioChannel. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24641/diff/3-4/
Keywords: checkin-needed

Comment 13

2 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/7cb3a5f4c42a
Keywords: checkin-needed

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7cb3a5f4c42a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S1 - 11/20
You need to log in before you can comment on or make changes to this bug.